Vis options panel #1783

w33ble · 2014-10-31T22:49:52Z

Built off of #1763 (merge that PR first)

This PR adds visualization options to allow for disabling elements (legend, tooltip) as well as custom vis options (like mode for histogram).

params are set on a vis_type, including defaults and an editor
The editor is used for the UI for setting the associated options
The new renderbots (introduced in Template vistype and Table Vis #1763) can now have their params refreshed
100% coverage for base and vislib renderbots

…ling of hierarchical, and spec'd out renderbots

…ls, use a controller, and provide UI for page size

…riter to ResponseWriter

Conflicts: src/kibana/plugins/vis_types/index.js test/unit/index.html

…t all

- wrap all vis types tests - wrap vislib tests - add basic renderbot and vislib renderbot tests

Conflicts: test/unit/index.html

Conflicts: src/kibana/components/agg_response/tabify/_response_writer.js src/kibana/partials/paginate_controls.html src/kibana/styles/_pagination.less

Tweak vis option styling, make section collapsed by default

spalger · 2014-11-05T23:21:21Z

LGTM

Vis options panel

Spencer Alger added 30 commits October 22, 2014 08:56

created chart_data component, normalized visLib to vislib, fixed spel…

0129cc5

…ling of hierarchical, and spec'd out renderbots

[spy/vis_details] added to the spy panel

a3d204b

[spy/table] provide a way for the table to read esResponse

331d797

[spy/visDetails] move vis details into plugins

de813c4

[vis_details_spy] don't include in the build

6d069c0

[spy] [paginate] allow paginated content to define location of contro…

6988adb

…ls, use a controller, and provide UI for page size

[agg_response/tabify] move tabify into agg_response component

198824f

[table_vis] move into own plugin

7187e06

[tests] updated module ids for moved files

315fb9e

[agg_response/hierarchical] move tests to reflect their new home

d40bdce

[vis_debug_spy] Renamed to 'vis debug spy'

d6f5044

[indexedArray] fix an inflector bug with four-letter keys

704e99d

[table_vis] updated file names and applied some basic style

020d408

[aggResp/tabify] support for splits, improved docs, and expanded RowW…

8900904

…riter to ResponseWriter

[vis] update isHierachical() check

0e81dad

[aggTable] create using the guts of the table spy

a50d693

[agg_response/tabify/buckets] Always pass the key, for consistency.

bd068ef

[agg_response/tabify/response] expand response class support for splits

7313773

[paginate] disable by specifying infinite/falsy rows per page

887a6d7

[table_vis] general clean up and comments

09a9adf

[agg_table] allow recursive rendering for passed in tableGroups

030abd7

Merge branch 'master' into template_vistype

2aa654a

Conflicts: src/kibana/plugins/vis_types/index.js test/unit/index.html

fix spelling of Hierarchical

d4b3f5c

save

8b10e52

[aggResponse/tabify] split out and enhance Table and TableSplit

1988d6e

[aggResponse/tabify] return the root TableSplit if we are splitting a…

6648605

…t all

[aggTable] split table directive in two

7a51894

[spy] fix pagination

cdd9dd5

[rows] make compatible with Inifite page size

46f7812

[aggTable] fix sort

7a253bb

Spencer Alger and others added 13 commits November 4, 2014 11:41

[aggTable] fix module name spelling

0991a80

[aggResp/tabify] rename tabify entry module

dc83e60

update the vis types tests

b737d04

- wrap all vis types tests - wrap vislib tests - add basic renderbot and vislib renderbot tests

Merge remote-tracking branch 'joe/vis-options' into template_vistype

d2c3411

Conflicts: test/unit/index.html

[tableVis] set the page size from the VisParams

6f64f8f

Merge branch 'template_vistype' into pr

7a92272

Conflicts: src/kibana/components/agg_response/tabify/_response_writer.js src/kibana/partials/paginate_controls.html src/kibana/styles/_pagination.less

[aggTable] hide the pageSize control in the pagination-controls

d757d49

[pagination] stabalize link styles

1c18742

Tweak vis option styling, make section collapsed by default

3c1ea77

[spy] scroll the content, not the toggle

6db07e8

[aggResp/tabify] fix the test module name

a56fe75

add more tests, fix issue where passed params were ignored

340cf0d

[aggTableGroup] be sure to clear the previous rows/columns

920e366

rashidkpc removed the WIP label Nov 4, 2014

w33ble and others added 7 commits November 4, 2014 16:21

minor test refactor, add tests for destroy

9df13b3

refactor data normalizers, add tests around render

5b9c14f

add exception tests for generic renderbot

9020702

Merge branch 'template_vistype' into vis-options

3454842

Merge pull request #2 from rashidkpc/pr/1783

2c76cdd

Tweak vis option styling, make section collapsed by default

don't pass new params, use params on the vis object

ed2d934

use a 3rd param to catch a fetch, instead of putting it in the directive

2e46879

w33ble added the review label Nov 5, 2014

Spencer Alger and others added 2 commits November 5, 2014 11:34

[visualize] allow specifying the editableVis

7494871

Merge branch 'template_vistype' into vis-options

9a9135f

merge master, fix conficts, fix vislib renderbot params test

e00b989

w33ble mentioned this pull request Nov 5, 2014

Template vistype and Table Vis #1763

Closed

spalger pushed a commit that referenced this pull request Nov 5, 2014

Merge pull request #1783 from w33ble/vis-options

e61d60c

Vis options panel

spalger merged commit e61d60c into elastic:master Nov 5, 2014

w33ble deleted the vis-options branch February 6, 2015 21:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vis options panel #1783

Vis options panel #1783

w33ble commented Oct 31, 2014

spalger commented Nov 5, 2014

Vis options panel #1783

Vis options panel #1783

Conversation

w33ble commented Oct 31, 2014

spalger commented Nov 5, 2014