Template vistype and Table Vis #1763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 22, 2014 08:56
…ling of hierarchical, and spec'd out renderbots
…ls, use a controller, and provide UI for page size
…riter to ResponseWriter
Conflicts: src/kibana/plugins/vis_types/index.js test/unit/index.html
Gets rid of the margins and the top border
spalger
force-pushed
the
template_vistype
branch
from
ae35f7d to
616da84
Compare
- wrap all vis types tests - wrap vislib tests - add basic renderbot and vislib renderbot tests
Conflicts: test/unit/index.html
|
For a term aggregation if term starts with a number it is centered:
|
added 5 commits
November 4, 2014 13:58
Conflicts: src/kibana/components/agg_response/tabify/_response_writer.js src/kibana/partials/paginate_controls.html src/kibana/styles/_pagination.less
|
@w33ble I've responded to all of your issues by updating the comments with a "response". All should be addressed and fixed. |
|
Poked through it again, LGTM. Just need to merge master. |
|
Moving to #1783 since all the changes are merged in there |
This was referenced Nov 6, 2014
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://goo.gl/OGTWY7