Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Coverage Overview follow-up 2 #164986

Merged
merged 4 commits into from
Aug 28, 2023
Merged

[Security Solution] Coverage Overview follow-up 2 #164986

merged 4 commits into from
Aug 28, 2023

Conversation

dplumlee
Copy link
Contributor

@dplumlee dplumlee commented Aug 28, 2023 •
edited by kibanamachine
Loading

Epic: https://github.com/elastic/security-team/issues/2905

Summary

  • Addresses the remaining comments from the previous follow-up
  • Updates the docs external link
  • Changes the column order in the grid according to this dashboard
  • Removes the detectionsCoverageOverview feature flag

Screenshots

Screenshot 2023-08-28 at 10 42 28 AM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dplumlee dplumlee added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team v8.10.0 v8.11.0 labels Aug 28, 2023
@dplumlee dplumlee self-assigned this Aug 28, 2023
@dplumlee dplumlee added the Team:Detections and Resp Security Detection Response Team label Aug 28, 2023
@dplumlee dplumlee marked this pull request as ready for review August 28, 2023 14:45
@dplumlee dplumlee requested a review from a team as a code owner August 28, 2023 14:45
@dplumlee dplumlee requested a review from banderror August 28, 2023 14:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@dplumlee dplumlee requested a review from a team as a code owner August 28, 2023 16:50
@banderror banderror added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Aug 28, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

banderror
banderror approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes and tested the app locally, including the fixes. Everything looks great and works as expected.

Thank you for tracking and addressing all the fixes and improvements @dplumlee, really appreciate it 👍

I left just a few minor comments for your consideration.

x-pack/plugins/security_solution/public/common/components/links_to_docs/links_translations.ts
export const COVERAGE_OVERVIEW_LINK_TEXT = i18n.translate(
'xpack.securitySolution.documentationLinks.coverageOverview.text',
{
defaultMessage: 'Learn more.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Oh interesting, this shows that link text sometimes can be very context-specific, and ideally should be passed as a property to the CoverageOverviewLink and other link components. Just something we could refactor in the future.

@banderror banderror changed the title [Security Solution] Coverage Overview docs update [Security Solution] Coverage Overview follow-up 2 Aug 28, 2023
@banderror
Copy link
Contributor

@dplumlee Just FYI I slightly updated the PR title, description, labels, and custom project fields

@dplumlee dplumlee enabled auto-merge (squash) August 28, 2023 19:33
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4473 4474 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 16.0MB 16.0MB +1.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 62.6KB 62.6KB -30.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dplumlee

@dplumlee dplumlee merged commit 3835392 into elastic:main Aug 28, 2023
@kibanamachine kibanamachine mentioned this pull request Aug 28, 2023
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 28, 2023
@dplumlee
[Security Solution] Coverage Overview follow-up 2 (elastic#164986)
9a4cccb 
(cherry picked from commit 3835392)
@dplumlee dplumlee deleted the coverage-overview-column-order branch August 28, 2023 21:44
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 29, 2023
@jloleysens
Merge branch 'main' into run-migrations-on-migrator
44333f6 
* main: (40 commits)
  Adjust migrations and elasticsearch service settings for serverless. (elastic#165050)
  [Security Solution] expandable flyout - add investigate in timeline f… (elastic#165025)
  [SecuritySolution] Hide create dashboard button from listing (elastic#164476)
  Construct HTTP log message only if needed (elastic#165057)
  [Security Solution] expandable flyout - add no data message in entities details and entities overview components (elastic#164955)
  Add functional tests for serverless security management UIs (elastic#164886)
  [api-docs] 2023-08-29 Daily api_docs build (elastic#165056)
  [Cloud Security][CIS GCP]cis gcp now use updated gcp field name + small last minute changes (elastic#164792)
  [Security Solution] Expandable flyout - update risk classification ui in entities overview (elastic#165022)
  [Security Solution] Fixes Preconfigured Connectors not working with Assistant (elastic#164900)
  [Security Solution] Coverage Overview follow-up 2 (elastic#164986)
  [DOCS] Add cross-link for other encryption key settings (elastic#165014)
  chore(slo): general enhancement (elastic#164723)
  Revert "[SOR] Allow optionally downgrading documents with a higher version model in API READ methods" (elastic#164991)
  [OAS] Add more Elasticsearch query rule examples (elastic#164386)
  [security_solution_cypress] Add support for options in EsArchiver.load (elastic#164988)
  [Event Log] Skip setting assets to hidden in serverless (elastic#164767)
  remove unneeded usages of isErrorResponse (elastic#164609)
  [Enterprise Search] Make network drive connector platinum (elastic#165007)
  [RAM] update api key to become public (elastic#164883)
  ...
@kibanamachine kibanamachine mentioned this pull request Aug 29, 2023
Merged
1 task
kibanamachine added a commit that referenced this pull request Aug 29, 2023
@kibanamachine @dplumlee
[8.10] [Security Solution] Coverage Overview follow-up 2 (#164986) (#…
7699da3 
…165045)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Security Solution] Coverage Overview follow-up 2
(#164986)](#164986)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Davis
Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-28T20:39:20Z","message":"[Security
Solution] Coverage Overview follow-up 2
(#164986)","sha":"3835392e329b1a3cc1dba0a1b6f36a36a87c1cfa","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Detections
and Resp","Team: SecuritySolution","Feature:Rule
Management","Team:Detection Rule
Management","v8.10.0","v8.11.0"],"number":164986,"url":"https://github.com/elastic/kibana/pull/164986","mergeCommit":{"message":"[Security
Solution] Coverage Overview follow-up 2
(#164986)","sha":"3835392e329b1a3cc1dba0a1b6f36a36a87c1cfa"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164986","number":164986,"mergeCommit":{"message":"[Security
Solution] Coverage Overview follow-up 2
(#164986)","sha":"3835392e329b1a3cc1dba0a1b6f36a36a87c1cfa"}}]}]
BACKPORT-->

Co-authored-by: Davis Plumlee <[email protected]>
@banderror banderror added release_note:feature Makes this part of the condensed release notes and removed release_note:skip Skip the PR/issue when compiling release notes labels Sep 6, 2023
@banderror banderror mentioned this pull request Sep 6, 2023
Merged
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banderror banderror banderror approved these changes

Assignees

@dplumlee dplumlee

Labels
bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management area release_note:feature Makes this part of the condensed release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dplumlee @elasticmachine @banderror @kibana-ci @kibanamachine