addresses comments

elastic · Aug 28, 2023 · d3dd375 · d3dd375
1 parent 1485cfe
commit d3dd375
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 25 deletions.
diff --git a/...ion_engine/rule_management/logic/coverage_overview/build_coverage_overview_mitre_graph.ts b/...ion_engine/rule_management/logic/coverage_overview/build_coverage_overview_mitre_graph.ts
@@ -15,6 +15,24 @@ import type { CoverageOverviewMitreSubTechnique } from '../../model/coverage_ove
 import type { CoverageOverviewMitreTactic } from '../../model/coverage_overview/mitre_tactic';
 import type { CoverageOverviewMitreTechnique } from '../../model/coverage_overview/mitre_technique';
 
+// The order the tactic columns will appear in on the coverage overview page
+const tacticOrder = [
+  'TA0043',
+  'TA0042',
+  'TA0001',
+  'TA0002',
+  'TA0003',
+  'TA0004',
+  'TA0005',
+  'TA0006',
+  'TA0007',
+  'TA0008',
+  'TA0009',
+  'TA0011',
+  'TA0010',
+  'TA0040',
+];
+
 export function buildCoverageOverviewMitreGraph(
   tactics: MitreTactic[],
   techniques: MitreTechnique[],
@@ -67,23 +85,6 @@ export function buildCoverageOverviewMitreGraph(
     }
   }
 
-  const tacticOrder = [
-    'TA0043',
-    'TA0042',
-    'TA0001',
-    'TA0002',
-    'TA0003',
-    'TA0004',
-    'TA0005',
-    'TA0006',
-    'TA0007',
-    'TA0008',
-    'TA0009',
-    'TA0011',
-    'TA0010',
-    'TA0040',
-  ];
-
   const sortedTactics = tactics.sort(
     (a, b) => tacticOrder.indexOf(a.id) - tacticOrder.indexOf(b.id)
   );

diff --git a/...erage_overview/mitre_subtechnique.test.ts → ...coverage_overview/mitre_technique.test.ts b/...erage_overview/mitre_subtechnique.test.ts → ...coverage_overview/mitre_technique.test.ts
diff --git a/...tection_engine/rule_management_ui/pages/coverage_overview/coverage_overview_dashboard.tsx b/...tection_engine/rule_management_ui/pages/coverage_overview/coverage_overview_dashboard.tsx
@@ -15,23 +15,27 @@ import { CoverageOverviewMitreTechniquePanelPopover } from './technique_panel_po
 import { CoverageOverviewFiltersPanel } from './filters_panel';
 import { useCoverageOverviewDashboardContext } from './coverage_overview_dashboard_context';
 
-const CoverageOverviewSubtitle = (
-  <EuiText color="subdued" size="s">
-    <span>{i18n.CoverageOverviewDashboardInformation}</span> <CoverageOverviewLink />
-  </EuiText>
+const CoverageOverviewHeaderComponent = () => (
+  <HeaderPage
+    title={i18n.COVERAGE_OVERVIEW_DASHBOARD_TITLE}
+    subtitle={
+      <EuiText color="subdued" size="s">
+        <span>{i18n.CoverageOverviewDashboardInformation}</span> <CoverageOverviewLink />
+      </EuiText>
+    }
+  />
 );
 
+const CoverageOverviewHeader = React.memo(CoverageOverviewHeaderComponent);
+
 const CoverageOverviewDashboardComponent = () => {
   const {
     state: { data },
   } = useCoverageOverviewDashboardContext();
 
   return (
     <>
-      <HeaderPage
-        title={i18n.COVERAGE_OVERVIEW_DASHBOARD_TITLE}
-        subtitle={CoverageOverviewSubtitle}
-      />
+      <CoverageOverviewHeader />
       <CoverageOverviewFiltersPanel />
       <EuiSpacer />
       <EuiFlexGroup gutterSize="m" className="eui-xScroll">