Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RCF to pick user fetching strategy #161546

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Add RCF to pick user fetching strategy #161546

merged 4 commits into from
Jul 10, 2023

Conversation

seanstory
Copy link
Member

@seanstory seanstory commented Jul 10, 2023 •
edited by kibanamachine
Loading

Summary

Part of elastic/connectors#1204

This adds a configuration for the sharepoint online native connector to allow it to choose between approaches when fetching users for DLS.

Checklist

For maintainers

@seanstory seanstory added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.9.0 v8.10.0 labels Jul 10, 2023
@seanstory seanstory requested a review from a team July 10, 2023 13:54
@seanstory seanstory mentioned this pull request Jul 10, 2023
Closed
navarone-feekery
navarone-feekery approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@navarone-feekery navarone-feekery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seanstory seanstory mentioned this pull request Jul 10, 2023
Merged
4 tasks
@seanstory
Copy link
Member Author

Updated the verbiage, and created elastic/connectors#1239 for connector clients verbiage updates

@seanstory seanstory enabled auto-merge (squash) July 10, 2023 19:13
@seanstory seanstory merged commit fd2ecdf into elastic:main Jul 10, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.5MB 2.5MB +743.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 408 412 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 487 491 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine mentioned this pull request Jul 10, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 10, 2023
@seanstory
Add RCF to pick user fetching strategy (elastic#161546)
e5a49fd 
## Summary

Part of elastic/connectors#1204

This adds a configuration for the sharepoint online native connector to
allow it to choose between approaches when fetching users for DLS.

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit fd2ecdf)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 10, 2023
@kibanamachine @seanstory
[8.9] Add RCF to pick user fetching strategy (#161546) (#161604)
6c8a8de 
# Backport

This will backport the following commits from `main` to `8.9`:
- [Add RCF to pick user fetching strategy
(#161546)](#161546)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sean
Story","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-10T22:06:09Z","message":"Add
RCF to pick user fetching strategy (#161546)\n\n## Summary\r\n\r\nPart
of https://github.com/elastic/connectors-python/issues/1204\r\n\r\nThis
adds a configuration for the sharepoint online native connector
to\r\nallow it to choose between approaches when fetching users for
DLS.\r\n\r\n\r\n### Checklist\r\n\r\n\r\n- [x] Any text added follows
[EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"fd2ecdfb27985044aa6e0c85662f23d5b000c255","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.9.0","v8.10.0"],"number":161546,"url":"https://github.com/elastic/kibana/pull/161546","mergeCommit":{"message":"Add
RCF to pick user fetching strategy (#161546)\n\n## Summary\r\n\r\nPart
of https://github.com/elastic/connectors-python/issues/1204\r\n\r\nThis
adds a configuration for the sharepoint online native connector
to\r\nallow it to choose between approaches when fetching users for
DLS.\r\n\r\n\r\n### Checklist\r\n\r\n\r\n- [x] Any text added follows
[EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"fd2ecdfb27985044aa6e0c85662f23d5b000c255"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161546","number":161546,"mergeCommit":{"message":"Add
RCF to pick user fetching strategy (#161546)\n\n## Summary\r\n\r\nPart
of https://github.com/elastic/connectors-python/issues/1204\r\n\r\nThis
adds a configuration for the sharepoint online native connector
to\r\nallow it to choose between approaches when fetching users for
DLS.\r\n\r\n\r\n### Checklist\r\n\r\n\r\n- [x] Any text added follows
[EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"fd2ecdfb27985044aa6e0c85662f23d5b000c255"}}]}]
BACKPORT-->

Co-authored-by: Sean Story <[email protected]>
@seanstory seanstory mentioned this pull request Jul 12, 2023
Merged
1 task
seanstory added a commit that referenced this pull request Jul 13, 2023
@seanstory
remove native config for selecting fetch strategy (#161798)
8175c8a 
## Summary

Part of elastic/search-team#5162

Effectively reverting #161546, as
the new strategy has completely replaced the old.

See also: elastic/connectors#1255

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 13, 2023
@seanstory
remove native config for selecting fetch strategy (elastic#161798)
33ecb62 
## Summary

Part of elastic/search-team#5162

Effectively reverting elastic#161546, as
the new strategy has completely replaced the old.

See also: elastic/connectors#1255

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 8175c8a)
kibanamachine added a commit that referenced this pull request Jul 13, 2023
@kibanamachine @seanstory
[8.9] remove native config for selecting fetch strategy (#161798) (#1…
49a4eee 
…61866)

# Backport

This will backport the following commits from `main` to `8.9`:
- [remove native config for selecting fetch strategy
(#161798)](#161798)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sean
Story","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-13T13:25:10Z","message":"remove
native config for selecting fetch strategy (#161798)\n\n##
Summary\r\n\r\nPart of
https://github.com/elastic/enterprise-search-team/issues/5162\r\n\r\nEffectively
reverting #161546, as\r\nthe new
strategy has completely replaced the old.\r\n\r\nSee also:
https://github.com/elastic/connectors-python/pull/1255\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8175c8a95d053cdcad6c8cf61dd767f90b797c58","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.9.0","v8.10.0"],"number":161798,"url":"https://github.com/elastic/kibana/pull/161798","mergeCommit":{"message":"remove
native config for selecting fetch strategy (#161798)\n\n##
Summary\r\n\r\nPart of
https://github.com/elastic/enterprise-search-team/issues/5162\r\n\r\nEffectively
reverting #161546, as\r\nthe new
strategy has completely replaced the old.\r\n\r\nSee also:
https://github.com/elastic/connectors-python/pull/1255\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8175c8a95d053cdcad6c8cf61dd767f90b797c58"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161798","number":161798,"mergeCommit":{"message":"remove
native config for selecting fetch strategy (#161798)\n\n##
Summary\r\n\r\nPart of
https://github.com/elastic/enterprise-search-team/issues/5162\r\n\r\nEffectively
reverting #161546, as\r\nthe new
strategy has completely replaced the old.\r\n\r\nSee also:
https://github.com/elastic/connectors-python/pull/1255\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8175c8a95d053cdcad6c8cf61dd767f90b797c58"}}]}]
BACKPORT-->

Co-authored-by: Sean Story <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemthompo leemthompo leemthompo left review comments

@sphilipse sphilipse sphilipse left review comments

@navarone-feekery navarone-feekery navarone-feekery approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.9.0 v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@seanstory @kibana-ci @kibanamachine @navarone-feekery @leemthompo @sphilipse