Skip to content

Commit

Permalink
[8.9] remove native config for selecting fetch strategy (#161798) (#1…
Browse files Browse the repository at this point in the history
…61866)

# Backport

This will backport the following commits from `main` to `8.9`:
- [remove native config for selecting fetch strategy
(#161798)](#161798)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sean
Story","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-13T13:25:10Z","message":"remove
native config for selecting fetch strategy (#161798)\n\n##
Summary\r\n\r\nPart of
https://github.com/elastic/enterprise-search-team/issues/5162\r\n\r\nEffectively
reverting #161546, as\r\nthe new
strategy has completely replaced the old.\r\n\r\nSee also:
https://github.com/elastic/connectors-python/pull/1255\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8175c8a95d053cdcad6c8cf61dd767f90b797c58","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.9.0","v8.10.0"],"number":161798,"url":"https://github.com/elastic/kibana/pull/161798","mergeCommit":{"message":"remove
native config for selecting fetch strategy (#161798)\n\n##
Summary\r\n\r\nPart of
https://github.com/elastic/enterprise-search-team/issues/5162\r\n\r\nEffectively
reverting #161546, as\r\nthe new
strategy has completely replaced the old.\r\n\r\nSee also:
https://github.com/elastic/connectors-python/pull/1255\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8175c8a95d053cdcad6c8cf61dd767f90b797c58"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161798","number":161798,"mergeCommit":{"message":"remove
native config for selecting fetch strategy (#161798)\n\n##
Summary\r\n\r\nPart of
https://github.com/elastic/enterprise-search-team/issues/5162\r\n\r\nEffectively
reverting #161546, as\r\nthe new
strategy has completely replaced the old.\r\n\r\nSee also:
https://github.com/elastic/connectors-python/pull/1255\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8175c8a95d053cdcad6c8cf61dd767f90b797c58"}}]}]
BACKPORT-->

Co-authored-by: Sean Story <[email protected]>
  • Loading branch information
kibanamachine and seanstory authored Jul 13, 2023
1 parent b6d3492 commit 49a4eee
Showing 1 changed file with 0 additions and 26 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1652,32 +1652,6 @@ export const NATIVE_CONNECTOR_DEFINITIONS: Record<string, NativeConnector | unde
validations: [],
value: false,
},
fetch_users_by_site: {
default_value: false,
depends_on: [{ field: 'use_document_level_security', value: true }],
display: DisplayType.TOGGLE,
label: i18n.translate(
'xpack.enterpriseSearch.nativeConnectors.sharepoint_online.configuration.fetchUsersBySiteLabel',
{
defaultMessage: 'Discover users by site membership',
}
),
options: [],
order: 8,
required: true,
sensitive: false,
tooltip: i18n.translate(
'xpack.enterpriseSearch.nativeConnectors.sharepoint_online.configuration.fetchUsersBySiteTooltip',
{
defaultMessage:
'When syncing only a small subset of sites, it can be more efficient to only fetch users who have access to those sites. This becomes increasingly inefficient the more sites (and the more users) concerned.',
}
),
type: FieldType.BOOLEAN,
ui_restrictions: [],
validations: [],
value: false,
},
},
features: {
[FeatureName.SYNC_RULES]: {
Expand Down

0 comments on commit 49a4eee

Please sign in to comment.