Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail test if it 'console.error's #16116

Merged
merged 3 commits into from
Jan 18, 2018
Merged

Fail test if it 'console.error's #16116

merged 3 commits into from
Jan 18, 2018

Conversation

kimjoar
Copy link
Contributor

@kimjoar kimjoar commented Jan 18, 2018 •
edited
Loading

Follow-up to #16112

@kimjoar kimjoar requested a review from cjcenizal January 18, 2018 09:35
cjcenizal
cjcenizal approved these changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjcenizal cjcenizal mentioned this pull request Jan 18, 2018
Closed
@kimjoar kimjoar merged commit 7b0b381 into elastic:master Jan 18, 2018
kimjoar added a commit to kimjoar/kibana that referenced this pull request Jan 18, 2018
@kimjoar
Fail test if it 'console.error's (elastic#16116)
0c7590c 
* Fail test if it 'console.error's

* oneOf -> oneOfType

* Fix react-color console.error
@kimjoar kimjoar mentioned this pull request Jan 18, 2018
Merged
kimjoar added a commit that referenced this pull request Jan 18, 2018
@kimjoar
Fail test if it 'console.error's (#16116) (#16131)
4da5d6f 
* Fail test if it 'console.error's

* oneOf -> oneOfType

* Fix react-color console.error
@kimjoar kimjoar added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jan 18, 2018
@njd5475 njd5475 mentioned this pull request Feb 20, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

Assignees
No one assigned
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.2.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimjoar @cjcenizal