Fail test if it 'console.error's (#16116)

* Fail test if it 'console.error's * oneOf -> oneOfType * Fix react-color console.error
elastic · Jan 18, 2018 · 7b0b381 · 7b0b381
1 parent 88ed489
commit 7b0b381
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 4 deletions.
diff --git a/src/dev/jest/config.json b/src/dev/jest/config.json
@@ -23,7 +23,8 @@
   },
   "setupFiles": [
     "<rootDir>/src/dev/jest/setup/babel_polyfill.js",
-    "<rootDir>/src/dev/jest/setup/enzyme.js"
+    "<rootDir>/src/dev/jest/setup/enzyme.js",
+    "<rootDir>/src/dev/jest/setup/throw_on_console_error.js"
   ],
   "coverageDirectory": "<rootDir>/target/jest-coverage",
   "coverageReporters": [

diff --git a/src/dev/jest/setup/throw_on_console_error.js b/src/dev/jest/setup/throw_on_console_error.js
@@ -0,0 +1,5 @@
+// Fail if a test ends up `console.error`-ing, e.g. if React logs because of a
+// failed prop types check.
+console.error = message => {
+  throw new Error(message);
+};
diff --git a/ui_framework/src/components/color_picker/color_picker.test.js b/ui_framework/src/components/color_picker/color_picker.test.js
@@ -11,6 +11,13 @@ let onChange;
 
 beforeEach(() => {
   onChange = sinon.spy();
+
+  // There's a `console.error` within `react-color`, so we're just "hiding it"
+  sinon.stub(console, 'error');
+});
+
+afterEach(() => {
+  console.error.restore();
 });
 
 test('renders KuiColorPicker', () => {

diff --git a/ui_framework/src/components/table/listing_table/listing_table.js b/ui_framework/src/components/table/listing_table/listing_table.js
@@ -127,7 +127,7 @@ export function KuiListingTable({
 
 KuiListingTable.propTypes = {
   header: PropTypes.arrayOf(
-    PropTypes.oneOf([
+    PropTypes.oneOfType([
       PropTypes.node,
       PropTypes.shape({
         content: PropTypes.node,
@@ -141,7 +141,7 @@ KuiListingTable.propTypes = {
   rows: PropTypes.arrayOf(PropTypes.shape({
     id: PropTypes.string,
     cells: PropTypes.arrayOf(
-      PropTypes.oneOf([
+      PropTypes.oneOfType([
         PropTypes.node,
         PropTypes.shape({
           content: PropTypes.node,

diff --git a/ui_framework/src/components/table/listing_table/listing_table_row.js b/ui_framework/src/components/table/listing_table/listing_table_row.js
@@ -55,7 +55,7 @@ KuiListingTableRow.propTypes = {
   row: PropTypes.shape({
     id: PropTypes.string,
     cells: PropTypes.arrayOf(
-      PropTypes.oneOf([
+      PropTypes.oneOfType([
         PropTypes.node,
         PropTypes.shape({
           content: PropTypes.node,