Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Added required fields to infra metrics client #142569

Merged
merged 5 commits into from
Oct 5, 2022
Merged

[APM] Added required fields to infra metrics client #142569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c6f91c
Added required fields to infra metrics client
MiriamAparicio Oct 4, 2022
9eddf10
add fields to the requests
MiriamAparicio Oct 5, 2022
657405f
Merge branch 'main' into improvements-infra-client
MiriamAparicio Oct 5, 2022
c932217
Merge branch 'main' into improvements-infra-client
MiriamAparicio Oct 5, 2022
f224270
[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…
kibanamachine Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/developer/plugin-list.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ as uiSettings within the code.

|{kib-repo}blob/{branch}/src/plugins/data_views/README.mdx[dataViews]
|The data views API provides a consistent method of structuring and formatting documents
and field lists across the various Kibana apps. Its typically used in conjunction with
and field lists across the various Kibana apps. It's typically used in conjunction with
<DocLink id="kibDevTutorialDataSearchAndSessions" section="high-level-search" text="SearchSource" /> for composing queries.


Expand Down
5 changes: 4 additions & 1 deletion ...r/lib/helpers/create_es_client/create_infra_metrics_client/create_infra_metrics_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ import { ESSearchRequest, InferSearchResponseOf } from '@kbn/es-types';
import { APMRouteHandlerResources } from '../../../../routes/typings';
import { getInfraMetricIndices } from '../../get_infra_metric_indices';

type InfraMetricsSearchParams = Omit<ESSearchRequest, 'index'>;
type InfraMetricsSearchParams = Omit<ESSearchRequest, 'index'> & {
size: number;
track_total_hits: boolean | number;
};

export type InfraMetricsClient = ReturnType<typeof createInfraMetricsClient>;

Expand Down
1 change: 1 addition & 0 deletions x-pack/plugins/apm/server/routes/infrastructure/get_host_names.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ export async function getContainerHostNames({

const response = await infraMetricsClient.search({
size: 0,
track_total_hits: false,
query: {
bool: {
filter: [
Expand Down
1 change: 1 addition & 0 deletions x-pack/plugins/apm/server/routes/services/get_service_instance_container_metadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ export const getServiceInstanceContainerMetadata = async ({

const response = await infraMetricsClient.search({
size: 1,
track_total_hits: false,
query: {
bool: {
filter: [
Expand Down
1 change: 1 addition & 0 deletions x-pack/plugins/apm/server/routes/services/get_service_overview_container_metadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export const getServiceOverviewContainerMetadata = async ({

const response = await infraMetricsClient.search({
size: 0,
track_total_hits: false,
query: {
bool: {
filter: [
Expand Down