[APM] Added required fields to infra metrics client #142569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiriamAparicio
added
Team:APM - DEPRECATED
|
Pinging @elastic/apm-ui (Team:APM) |
kpatticha
reviewed
Oct 4, 2022
| @@ -9,7 +9,12 @@ import { ESSearchRequest, InferSearchResponseOf } from '@kbn/es-types'; | |||
| import { APMRouteHandlerResources } from '../../../../routes/typings'; | |||
| import { getInfraMetricIndices } from '../../get_infra_metric_indices'; | |||
|
|
|||
| type InfraMetricsSearchParams = Omit<ESSearchRequest, 'index'>; | |||
| type InfraMetricsSearchParams = Omit<ESSearchRequest, 'index'> & { | |||
| body: { | |||
There was a problem hiding this comment.
Do you really need the body here?
There was a problem hiding this comment.
I was following @sqren suggestion here: #141735 (comment)
There was a problem hiding this comment.
No we don't, my bad! I suggested it based on what we have for the apmEventClient:
But the infraMetricsClient doesn't have a body params so we can omit that.
|
Thanks for adding the required fields. 💯 |
sorenlouv
reviewed
Oct 4, 2022
Comment on lines
13
to
16
| body: { | ||
| size: number; | ||
| track_total_hits: boolean | number; | ||
| }; |
There was a problem hiding this comment.
Suggested change
| body: { | |
| size: number; | |
| track_total_hits: boolean | number; | |
| }; | |
| size: number; | |
| track_total_hits: boolean | number; |
MiriamAparicio
force-pushed
the
improvements-infra-client
branch
from
cebf5e6 to
9eddf10
Compare
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
|
@sqren can you take a look at |
sorenlouv
approved these changes
Oct 5, 2022
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 11, 2022
* Added required fields to infra metrics client * add fields to the requests * [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs' Co-authored-by: kibanamachine <[email protected]>
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 14, 2022
* Added required fields to infra metrics client * add fields to the requests * [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs' Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little improvement in the infra metrics client, added
sizeandtrack_total_hitsas required fields.