A11y test for rules and connectors

[bhavyarm]

A11y test for rules and connectors - #139220
Meta - #51456

A11y bugs on rules connectors page:

• Form elements must have labels error on intervalInput on create rules page #141230
• Select element must have an accessible name error on intervalInputUnit  #141231
• (Accessibility) Ensures every ID attribute value is unique #144953

[bhavyarm]

@1Copenut I have a few more a11y errors on this app along with these two bugs which I already logged. I am going to ping you for a zoom to see about the failures in this test and if they are valid a11y issues. Thanks!

• Form elements must have labels error on intervalInput on create rules page #141230
• Select element must have an accessible name error on intervalInputUnit  #141231

Here are the screenshots -

[bhavyarm]

@1Copenut this is ready for you to debug. Good luck. Thanks :)

[elasticmachine]

Pinging @elastic/kibana-accessibility (Project:Accessibility)

[1Copenut]

LGTM! I left a comment about further findings on the Rules Panel block we've been troubleshooting.

[1Copenut]

@bhavyarm Agree on skipping this block for now. I talked with Chandler about this issue yesterday and have a few ideas I'm still exploring.

When I moved the await a11y.testAppSnapshot() to the top of the block, it caused the first input to throw an error and the "one rule must be applied" message to appear, which I would not expect to happen. The accessibility test should not be affecting the DOM, so I'm looking more closely at the helper itself. Is it injecting a script, and is the block under test using mutation observer in the React code. I'll gather what I can find and open an investigation issue with Kibana Ops.

it.skip('a11y test on inputs on rules panel', async () => {
  await a11y.testAppSnapshot();
  // Causes the first input to lose focus, throw error code
  // Also causes the "one rule must be applied" error to appear
  await testSubjects.click('ruleNameInput');
  await testSubjects.setValue('ruleNameInput', 'testRule');
  ...

[bhavyarm]

Thank you very much @1Copenut

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 538fb97

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id	before	after	diff
osquery	1	2	+1

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	19	21	+2
fleet	59	65	+6
osquery	108	113	+5
securitySolution	441	447	+6
total			+19

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	20	22	+2
fleet	67	73	+6
osquery	109	115	+6
securitySolution	518	524	+6
total			+20

History

• 💚 Build #88494 succeeded 8f5c830
• 💚 Build #88458 succeeded 09d6c16
• 💚 Build #88262 succeeded 1825761
• 💔 Build #87788 failed acfbef6efd2cb50e17c22733cf9d5531e9c9ca60
• 💔 Build #87292 failed 51b3007d56d403c3b930b1be120ebc13e8362e10
• 💔 Build #86355 failed 0e5b00b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

[kibanamachine]

💚 All backports created successfully

Status	Branch	Result
✅	8.5
✅	8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

[kibanamachine]

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

[kibanamachine]

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

[kibanamachine]

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.