Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Accessibility) Ensures every ID attribute value is unique #144953

Closed
1Copenut opened this issue Nov 9, 2022 · 2 comments · Fixed by #145175
Closed

(Accessibility) Ensures every ID attribute value is unique #144953

1Copenut opened this issue Nov 9, 2022 · 2 comments · Fixed by #145175
Assignees
@doakalexi
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting/RulesManagement Issues related to the Rules Management UX good first issue low hanging fruit Project:Accessibility Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) WCAG A

Comments

@1Copenut
Copy link
Contributor

1Copenut commented Nov 9, 2022

Steps to reproduce

  1. Log into the Kibana Stack Management > Rules page
  2. Click the Create New Rule button
  3. In the Create rule flyout, click Anomaly at the bottom
  4. Run the axe browser plugin (from Dev tools) when the vendor icons are on screen
  5. Verify there are two Minor duplicated ID errors

Screen Shot 2022-11-09 at 4 46 17 PM

Actual Result

  • Axe browser plugin shows 2 violations for duplicated IDs

Expected Result

  • Axe browser plugin shows 0 violations with duplicated IDs

Kibana Version:
Latest

OS:
MacOS Monterey

Browser:
Chrome

Relevant WCAG Criteria: 4.1.1: Parsing - Level A
@1Copenut 1Copenut added bug Fixes for quality problems that affect the customer experience Project:Accessibility WCAG A Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesManagement Issues related to the Rules Management UX labels Nov 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@1Copenut 1Copenut mentioned this issue Nov 9, 2022
Merged
@ersin-erdal ersin-erdal moved this from Awaiting Triage to Todo in AppEx: ResponseOps - Execution & Connectors Nov 10, 2022
@ersin-erdal ersin-erdal added the good first issue low hanging fruit label Nov 10, 2022
@doakalexi doakalexi self-assigned this Nov 14, 2022
@doakalexi doakalexi mentioned this issue Nov 14, 2022
Merged
1 task
@doakalexi doakalexi moved this from Todo to In Progress in AppEx: ResponseOps - Execution & Connectors Nov 14, 2022
@doakalexi doakalexi moved this from In Progress to In Review in AppEx: ResponseOps - Execution & Connectors Nov 14, 2022
doakalexi added a commit that referenced this issue Nov 15, 2022
@doakalexi
[ResponseOps][Accessibility] Ensures every ID attribute value is uniq…
ca8106e 
…ue (#145175)

Resolves #144953
## Summary

Changed the labels for pagerduty, x-matters, and teams logo svgs.

### Checklist

- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))

### To verify

- Log into the Kibana Stack Management > Rules page
- Click the Create New Rule button
- In the Create rule flyout, select a rule and make sure the list of
connectors is showing
- Run the [axe browser plugin](https://deque.com/axe) (from Dev tools)
when the vendor icons are on screen
- Verify that you see 0 duplicated ID errors instead of two.
Repository owner moved this from In Review to Done in AppEx: ResponseOps - Execution & Connectors Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doakalexi doakalexi

Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting/RulesManagement Issues related to the Rules Management UX good first issue low hanging fruit Project:Accessibility Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) WCAG A
Projects
No open projects
AppEx: ResponseOps - Execution & Connectors
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ResponseOps][Accessibility] Ensures every ID attribute value is unique doakalexi/kibana
4 participants
@1Copenut @elasticmachine @ersin-erdal @doakalexi