Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Fleet package verification UI text #136053

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Update Fleet package verification UI text #136053

merged 2 commits into from
Jul 11, 2022

Conversation

bmorelli25
Copy link
Member

Summary

Updates the UI text added in #135928. It looks like the team still plans to add a documentation link and modal, so we may need to revisit this in the future.

@bmorelli25 bmorelli25 added Team:Docs release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.4.0 labels Jul 8, 2022
@bmorelli25 bmorelli25 self-assigned this Jul 8, 2022
@bmorelli25 bmorelli25 requested a review from hop-dev July 11, 2022 17:12
@bmorelli25 bmorelli25 marked this pull request as ready for review July 11, 2022 17:13
@bmorelli25 bmorelli25 requested a review from a team as a code owner July 11, 2022 17:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@bmorelli25
Copy link
Member Author

Hi, @hop-dev! Can you take a look at these recommendations?

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Fleet Cypress Tests / Add Integration - Real API should install integration without policy

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 847.1KB 847.0KB -57.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bmorelli25

hop-dev
hop-dev approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@hop-dev hop-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll ping you as a reviewer on the modal PR which I'll have up tomorrow as I'm struggling with the wording!

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jul 11, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@bmorelli25
Copy link
Member Author

Looks good, I'll ping you as a reviewer on the modal PR which I'll have up tomorrow as I'm struggling with the wording!

Perfect!

@bmorelli25 bmorelli25 merged commit e5e494b into elastic:main Jul 11, 2022
@bmorelli25 bmorelli25 deleted the ui-text-updates branch July 11, 2022 22:35
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hop-dev hop-dev hop-dev approved these changes

Assignees

@bmorelli25 bmorelli25

Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Docs Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI text review: Fleet package verification
5 participants
@bmorelli25 @elasticmachine @kibana-ci @hop-dev @kibanamachine