-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Display package verification status #135928
Conversation
0d1a1f4
to
0a17655
Compare
Pinging @elastic/fleet (Team:Fleet) |
@@ -4082,6 +4082,9 @@ | |||
"encrypted_saved_object_encryption_key_required" | |||
] | |||
} | |||
}, | |||
"package_verification_key_id": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if the key ID is out of place on the status endpoint, I contemplated having it on its own endpoint but that also seemed excessive for one value which is unchanging and almost like config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
1626916
to
c867a12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor comments but overall LGTM 🚀
x-pack/plugins/fleet/public/applications/integrations/layouts/default.tsx
Show resolved
Hide resolved
...ins/fleet/public/applications/integrations/sections/epm/screens/detail/overview/overview.tsx
Show resolved
Hide resolved
...ins/fleet/public/applications/integrations/sections/epm/screens/detail/overview/overview.tsx
Show resolved
Hide resolved
x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/home/index.tsx
Show resolved
Hide resolved
c867a12
to
30ecf43
Compare
💛 Build succeeded, but was flakyFailed CI StepsTest FailuresMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @hop-dev |
Summary
Part of #133822
if the package verification feature flag is enabled, show which packages are unverified in the UI:
Additional changes:
package_verification_key_id
to the fleet status responseNOTE: there are a few TODOs in the code where I will need to add a documentation link when its available, I don't know what other people do when a link isn't ready yet?
Screenshots
Installed integrations: new labels, callout and icon on tab

Tab icon still visible when not on tab:

Callout also displayed on integrations overview:

Testing steps
docker run -p 8080:8080 docker.elastic.co/observability-ci/package-registry/distribution:PR-463
xpack.fleet.registryUrl: http://localhost:8080
xpack.fleet.packageVerification.gpgKeyPath: /tmp/NOT_THE_ELASTIC_KEY.txt
Checklist
Delete any items that are not applicable to this PR.