[Security Solution][Endpoint][Trusted Apps] Trusted Apps post port cleanup

[ashokaditya]

refs /pull/129208

Summary

• Removes redundant empty state component
• updates translation vars to be consistent with the rest of the trusted apps translation vars
• updates ExceptionListTypeEnum for ENDPOINT_TRUSTED_APPS

[elasticmachine]

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

[dasansol92]

I don't remember exactly if we filter by the list type somewhere. I know we use most of the times the list_id but just want to make sure we don't break the existing exception list container for trusted apps when upgrading.
Also wondering if we should include a migration script to update the existing trusted apps container.

[ashokaditya]

@yctercero @marshallmain What else needs to be changed in order for this to work for older TA containers? This change is for the sake of consistency with other artifact names. I think when TAs was the first and only artifact just endpoint made sense but not so much now with more artifacts. Actually endpoint_events should also be renamed to endpoint_event_filters, but we can do that in a new PR if you all agree. Thanks for your help on this.

[ashokaditya]

@madirey Not sure if this is the file in question, that needs to be updated? https://github.com/elastic/kibana/blob/main/x-pack/plugins/lists/server/saved_objects/migrations.ts

[yctercero]

@ashokaditya we'd chatted about updating migrations in that file you linked. How's that going?

[ashokaditya]

@yctercero I've not had a chance to get to it. I'll get to it this week. Thanks for following up.

[pzl]

good, assuming @dasansol92 's comment on that list type enum gets addressed

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 79c5858
• Storybooks Preview
• Webpack Bundle Analyzer

Failed CI Steps

• FTR Configs #21

Test Failures

• [job] [logs] FTR Configs #21 / ObservabilityApp Observability Rule Details page Page components maps correctly the rule type with the human readable rule type

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
lists	147.6KB	147.6KB	+13.0B
securitySolution	5.2MB	5.2MB	-20.0B
total			-7.0B

History

• 💔 Build #56478 failed 4108986
• 💛 Build #54249 was flaky d4d6d86
• 💔 Build #54178 failed ca5dbc1
• 💔 Build #53449 failed 2b64016
• 💚 Build #50748 succeeded 8a22ef8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya

[dhurley14]

Hi @ashokaditya is this work still in progress? If not can we close the PR? We are still receiving reminders from slack's github bot for this PR.

[ashokaditya]

Hi @ashokaditya is this work still in progress? If not can we close the PR? We are still receiving reminders from slack's github bot for this PR.

Sorry I've not gotten around to work on it layely. I'll close this for now and reopen it when it's ready for review again.