[Security Solution][Endpoint] Port trusted apps to `ArtifactlsListPage` component #129208

ashokaditya · 2022-04-01T14:12:36Z

Summary

Ported Trusted Apps UI to use ArtifactsListPage component.
Updated tests
Removed unused components/files
Add tests for trusted app form

Checklist

Unit or functional tests were updated or added to match the most common scenarios

fixes elastic/security-team/issues/3092

without any trusted app entries, it should see the trusted empty page

…istPage-component

refs 6a792fc

…istPage-component

paul-tavares

Left a question about a change you made in the newer url_routing utilities, but looks good to me for merge.

Love the amount of modules/code we removed

paul-tavares · 2022-04-20T19:46:36Z

x-pack/plugins/security_solution/public/management/common/url_routing/utils.ts

-export const isDefaultOrMissing = <T>(value: T | undefined, defaultValue: T) => {
-  return value === undefined || value === defaultValue;
+export const isDefaultOrMissing = <T>(value: T | undefined | 0, defaultValue: T) => {
+  return value === undefined || value === defaultValue || value === 0;


Why did you add 0 here? 😕

Note: I'm hopping that these new set of utilities here will handle only the "new" type of our standardized URL params - like page is 1 based, while pages that still use page index should be using the older routing functions.

Yeah, so one of the routing tests was expecting the page to be 0 instead of 1 when the URL params were manually set to the default page (which is 0) or page=0. See here. I'm assuming, in this case, it should be reset to 1.

we should not be using page=0 for new pages, as we agreed that going forward they all should be "1-based". We also should not be using MANAGEMENT_DEFAULT_PAGE because that holds a page index (0-based) and not a page number (1-based). Actually - we probably don't even need a "DEFULT_PAGE" const (I don't remember why we even added it, but it was when we first created the plugin in Kibana)

...solution/public/management/components/artifact_list_page/components/artifact_flyout.test.tsx

...ck/plugins/security_solution/public/management/pages/trusted_apps/view/trusted_apps_list.tsx

…istPage-component

review suggestions

defaults to `m`

…istPage-component

MadameSheema · 2022-04-21T16:14:44Z

@elasticmachine merge upstream

…istPage-component

kibana-ci · 2022-04-21T18:28:46Z

💛 Build succeeded, but was flaky

Test Failures

[job] [logs] Security Solution Tests / Alerts timeline Privileges: can crud should allow a user with crud privileges to attach alerts to cases

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2775	2756	-19

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	4.8MB	4.8MB	-22.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	248.1KB	248.0KB	-23.0B

Unknown metric groups

async chunk count

id	before	after	diff
`securitySolution`	24	23	-1

ESLint disabled line counts

id	before	after	diff
`securitySolution`	449	445	-4

Total ESLint disabled count

id	before	after	diff
`securitySolution`	518	514	-4

History

💔 Build #39793 failed 83c4e1c
💔 Build #39787 failed 06f0330
💔 Build #39597 failed 0567f36
💔 Build #39496 failed 2b2509d
💔 Build #39386 failed d89c788657d3bf90ce454dbb48d7bad8846d642a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya

refs elastic/pull/129208

…e` component (elastic#129208) * move validations to artifacts fixes elastic/security-team/issues/3092 * use ArtifactsListPage fixes elastic/security-team/issues/3092 * Remove redundant files fixes elastic/security-team/issues/3092 * Update trusted app list ftr test fixes elastic/security-team/issues/3092 * fix test mock fixes elastic/security-team/issues/3092 * add trusted app form tests fixes elastic/security-team/issues/3092 * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * default page index to 1 when set to 0 refs elastic/pull/129099/commits/b688d505b460964117ba1a303b417760b13a2888 * add tests for new routing methods refs elastic/pull/129099/ * review changes fixes elastic/security-team/issues/3092 * update fleet integration test without any trusted app entries, it should see the trusted empty page * update translation again after merge refs 6a792fc * add a test for search field KQL review suggestions * remove redundant flyout size defaults to `m` Co-authored-by: kibanamachine <[email protected]>

ashokaditya self-assigned this Apr 1, 2022

ashokaditya added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.3.0 labels Apr 1, 2022

ashokaditya force-pushed the task/olm-3092-port-trusted-apps-to-ArtifactListPage-component branch 14 times, most recently from 46d0792 to abc21e7 Compare April 7, 2022 11:22

ashokaditya and others added 5 commits April 7, 2022 13:39

move validations to artifacts

e37c34c

fixes elastic/security-team/issues/3092

use ArtifactsListPage

5599cc2

fixes elastic/security-team/issues/3092

Remove redundant files

b91215b

fixes elastic/security-team/issues/3092

Update trusted app list ftr test

c90fba3

fixes elastic/security-team/issues/3092

fix test mock

b296f41

fixes elastic/security-team/issues/3092

ashokaditya force-pushed the task/olm-3092-port-trusted-apps-to-ArtifactListPage-component branch from abc21e7 to 8e14218 Compare April 7, 2022 11:39

ashokaditya marked this pull request as ready for review April 7, 2022 11:40

ashokaditya requested review from a team as code owners April 7, 2022 11:40

ashokaditya requested review from joeypoon and dasansol92 April 7, 2022 11:40

ashokaditya force-pushed the task/olm-3092-port-trusted-apps-to-ArtifactListPage-component branch 4 times, most recently from 03ac500 to 880485e Compare April 20, 2022 14:49

ashokaditya added 2 commits April 20, 2022 16:52

review changes

fbaa8c7

fixes elastic/security-team/issues/3092

update fleet integration test

534efeb

without any trusted app entries, it should see the trusted empty page

ashokaditya force-pushed the task/olm-3092-port-trusted-apps-to-ArtifactListPage-component branch from 880485e to 534efeb Compare April 20, 2022 14:53

ashokaditya added 2 commits April 20, 2022 17:04

Merge branch 'main' into task/olm-3092-port-trusted-apps-to-ArtifactL…

6a792fc

…istPage-component

update translation again after merge

2b2509d

refs 6a792fc

ashokaditya requested a review from paul-tavares April 20, 2022 17:54

Merge branch 'main' into task/olm-3092-port-trusted-apps-to-ArtifactL…

0567f36

…istPage-component

paul-tavares approved these changes Apr 20, 2022

View reviewed changes

ashokaditya and others added 4 commits April 21, 2022 12:12

Merge branch 'main' into task/olm-3092-port-trusted-apps-to-ArtifactL…

8527db8

…istPage-component

add a test for search field KQL

3d2cdbc

review suggestions

remove redundant flyout size

87a649e

defaults to `m`

Merge branch 'main' into task/olm-3092-port-trusted-apps-to-ArtifactL…

06f0330

…istPage-component

ashokaditya enabled auto-merge (squash) April 21, 2022 12:06

ashokaditya changed the title ~~[Security Solution][Endpoint] Port trusted apps to ArtifactlLstPage component~~ [Security Solution][Endpoint] Port trusted apps to ArtifactlsListPage component Apr 21, 2022

Update trusted_apps_list.test.tsx

83c4e1c

Merge branch 'main' into task/olm-3092-port-trusted-apps-to-ArtifactL…

4d287a6

…istPage-component

ashokaditya merged commit ef3bd04 into elastic:main Apr 21, 2022

ashokaditya mentioned this pull request Apr 26, 2022

[Security Solution][Endpoint][Trusted Apps] Trusted Apps post port cleanup #130959

Closed

ashokaditya added a commit to ashokaditya/kibana that referenced this pull request Apr 26, 2022

Leftover cleanup

3c2c73e

refs elastic/pull/129208

ashokaditya deleted the task/olm-3092-port-trusted-apps-to-ArtifactListPage-component branch November 29, 2022 13:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Endpoint] Port trusted apps to `ArtifactlsListPage` component #129208

[Security Solution][Endpoint] Port trusted apps to `ArtifactlsListPage` component #129208

ashokaditya commented Apr 1, 2022 •

edited

Loading

paul-tavares left a comment

paul-tavares Apr 20, 2022

ashokaditya Apr 21, 2022

paul-tavares Apr 21, 2022

MadameSheema commented Apr 21, 2022

kibana-ci commented Apr 21, 2022

async chunk count

ESLint disabled line counts

Total ESLint disabled count

[Security Solution][Endpoint] Port trusted apps to ArtifactlsListPage component #129208

[Security Solution][Endpoint] Port trusted apps to ArtifactlsListPage component #129208

Conversation

ashokaditya commented Apr 1, 2022 • edited Loading

Summary

Checklist

paul-tavares left a comment

Choose a reason for hiding this comment

paul-tavares Apr 20, 2022

Choose a reason for hiding this comment

ashokaditya Apr 21, 2022

Choose a reason for hiding this comment

paul-tavares Apr 21, 2022

Choose a reason for hiding this comment

MadameSheema commented Apr 21, 2022

kibana-ci commented Apr 21, 2022

💛 Build succeeded, but was flaky

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

async chunk count

ESLint disabled line counts

Total ESLint disabled count

History

[Security Solution][Endpoint] Port trusted apps to `ArtifactlsListPage` component #129208

[Security Solution][Endpoint] Port trusted apps to `ArtifactlsListPage` component #129208

ashokaditya commented Apr 1, 2022 •

edited

Loading