Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.2.1][Security Solution][Session view] fix full screen session view margin #130496

Merged

Conversation

zizhouW
Copy link

@zizhouW zizhouW commented Apr 18, 2022

Issue: #130369

  • Use padding instead of margin for full screen session view spacing, so that session view detail panel accordions expand icons will show without being truncated

image

  • Also to fix that session view details panel should have full height so border will display properly on the edges

@zizhouW zizhouW requested a review from a team April 18, 2022 18:43
@zizhouW zizhouW requested a review from a team as a code owner April 18, 2022 18:43
@zizhouW zizhouW self-assigned this Apr 18, 2022
@zizhouW zizhouW added auto-backport Deprecated - use backport:version if exact versions are needed Team:Threat Hunting:Investigations Security Solution Investigations Team Team: AWP: Platform Adaptive Workload Protection Platform team from Security Solution v8.3.0 v8.2.1 release_note:skip Skip the PR/issue when compiling release notes labels Apr 18, 2022
Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kqualters-elastic kqualters-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@zizhouW zizhouW enabled auto-merge (squash) April 18, 2022 19:22
@zizhouW zizhouW merged commit 08d61f3 into elastic:main Apr 18, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.8MB 4.8MB +51.0B
sessionView 61.1KB 61.1KB -24.0B
total +27.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @zizhouW

kibanamachine pushed a commit that referenced this pull request Apr 18, 2022
… margin (#130496)

* Fix right spacing of full screen session view

* Add full height to session view detail panel

(cherry picked from commit 08d61f3)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 18, 2022
… margin (#130496) (#130504)

* Fix right spacing of full screen session view

* Add full height to session view detail panel

(cherry picked from commit 08d61f3)

Co-authored-by: Jack <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 19, 2022
…disable-server-side

* 'main' of github.com:elastic/kibana: (103 commits)
  [Osquery] Update eslint config (elastic#129637)
  [Uptime] Update monitor saved object mappings (elastic#130433)
  Add links to metricbeat module docs (elastic#130519)
  Add link to troubleshooting guide in confirm data copy (elastic#130420)
  [Step 3] Cleanup charts plugin (elastic#130132)
  [Visualize] Adds a deprecation warning to the pie app (elastic#130447)
  [Maps] fix vector tile load errors not displayed in legend (elastic#130395)
  [CI] Split alerting-api-integration tests into separate cigroups (elastic#130414)
  [CI] Use spot instances for default cigroups in PR CI (elastic#130476)
  [functional-tests] TimePicker optimizations (elastic#130200)
  [kbn/pm] use stable module ids in dist (elastic#130497)
  [8.2.1][Security Solution][Session view] fix full screen session view margin (elastic#130496)
  Fix wrong config in comments (elastic#130378)
  Add deprecated telemetry (elastic#130458)
  Add eslint rule to support breaking up packages (elastic#130483)
  [Security Solution][Endpoint] Fix test stability and un-skip flaky tests (elastic#130176)
  Update object types for SharePoint Online external connector (elastic#130478)
  [Workplace Search] Fix broken feedback link (elastic#130475)
  Rename the term "execution" in config to "run" (elastic#130172)
  [Cloud Posture] use index with keyword mapping (elastic#130456)
  ...

# Conflicts:
#	docs/user/reporting/index.asciidoc
#	x-pack/plugins/reporting/public/types.ts
#	x-pack/plugins/screenshotting/server/screenshots/index.test.ts
#	x-pack/plugins/screenshotting/server/screenshots/index.ts
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
… margin (elastic#130496)

* Fix right spacing of full screen session view

* Add full height to session view detail panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team: AWP: Platform Adaptive Workload Protection Platform team from Security Solution Team:Threat Hunting:Investigations Security Solution Investigations Team v8.2.1 v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants