Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the term "execution" in config to "run" #130172

Merged
merged 6 commits into from
Apr 18, 2022

Conversation

ersin-erdal
Copy link
Contributor

@ersin-erdal ersin-erdal commented Apr 13, 2022

fixes: #129195

rename:

  • xpack.alerting.execution.timeout -> xpack.alerting.run.timeout
  • xpack.alerting.execution.actions.max -> xpack.alerting.run.actions.max
  • xpack.alerting.execution.ruleTypeOverrides[x].timeout -> xpack.alerting.run.ruleTypeOverrides[x].timeout

@ersin-erdal ersin-erdal added release_note:fix Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.3.0 v8.2.1 labels Apr 13, 2022
@ersin-erdal ersin-erdal marked this pull request as ready for review April 14, 2022 10:54
@ersin-erdal ersin-erdal requested review from a team as code owners April 14, 2022 10:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise docs LGTM

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should remove the v8.2.1 label as I believe this should still be going into 8.2.0?

@mikecote mikecote removed the v8.2.1 label Apr 18, 2022
@mikecote
Copy link
Contributor

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mikecote mikecote merged commit f962ff2 into elastic:main Apr 18, 2022
kibanamachine pushed a commit that referenced this pull request Apr 18, 2022
* Rename the term "execution" in config to "run"

* Rename the term "execution" in config to "run"

* Rename the overlooked terms

* [DOCS] Fix example indentation

* Update docs/user/alerting/troubleshooting/alerting-common-issues.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>

Co-authored-by: lcawl <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit f962ff2)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@ersin-erdal ersin-erdal deleted the 129195-rename-execution branch April 18, 2022 17:16
kibanamachine added a commit that referenced this pull request Apr 18, 2022
* Rename the term "execution" in config to "run"

* Rename the term "execution" in config to "run"

* Rename the overlooked terms

* [DOCS] Fix example indentation

* Update docs/user/alerting/troubleshooting/alerting-common-issues.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>

Co-authored-by: lcawl <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit f962ff2)

Co-authored-by: Ersin Erdal <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 19, 2022
…disable-server-side

* 'main' of github.com:elastic/kibana: (103 commits)
  [Osquery] Update eslint config (elastic#129637)
  [Uptime] Update monitor saved object mappings (elastic#130433)
  Add links to metricbeat module docs (elastic#130519)
  Add link to troubleshooting guide in confirm data copy (elastic#130420)
  [Step 3] Cleanup charts plugin (elastic#130132)
  [Visualize] Adds a deprecation warning to the pie app (elastic#130447)
  [Maps] fix vector tile load errors not displayed in legend (elastic#130395)
  [CI] Split alerting-api-integration tests into separate cigroups (elastic#130414)
  [CI] Use spot instances for default cigroups in PR CI (elastic#130476)
  [functional-tests] TimePicker optimizations (elastic#130200)
  [kbn/pm] use stable module ids in dist (elastic#130497)
  [8.2.1][Security Solution][Session view] fix full screen session view margin (elastic#130496)
  Fix wrong config in comments (elastic#130378)
  Add deprecated telemetry (elastic#130458)
  Add eslint rule to support breaking up packages (elastic#130483)
  [Security Solution][Endpoint] Fix test stability and un-skip flaky tests (elastic#130176)
  Update object types for SharePoint Online external connector (elastic#130478)
  [Workplace Search] Fix broken feedback link (elastic#130475)
  Rename the term "execution" in config to "run" (elastic#130172)
  [Cloud Posture] use index with keyword mapping (elastic#130456)
  ...

# Conflicts:
#	docs/user/reporting/index.asciidoc
#	x-pack/plugins/reporting/public/types.ts
#	x-pack/plugins/screenshotting/server/screenshots/index.test.ts
#	x-pack/plugins/screenshotting/server/screenshots/index.ts
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
* Rename the term "execution" in config to "run"

* Rename the term "execution" in config to "run"

* Rename the overlooked terms

* [DOCS] Fix example indentation

* Update docs/user/alerting/troubleshooting/alerting-common-issues.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>

Co-authored-by: lcawl <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Alerting release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.2.0 v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename xpack.alerting.execution configuration to xpack.alerting.run
7 participants