Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Add Content plugin #129108

Merged
merged 5 commits into from
Apr 4, 2022
Merged

[Enterprise Search] Add Content plugin #129108

merged 5 commits into from
Apr 4, 2022

Conversation

scottybollinger
Copy link
Contributor

@scottybollinger scottybollinger commented Mar 31, 2022 •
edited
Loading

Summary

Add the new Enterprise Search Content plugin back to Kibana. This was originally added as a gated plugin here, but that caused some issues with integration tests, so it was referred here. This PR adds the un-gated version for 8.3.

This also adds the server plugin.ts registration as well, which was missed before.

@scottybollinger scottybollinger added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Team:EnterpriseSearch v8.3.0 labels Mar 31, 2022
@scottybollinger scottybollinger marked this pull request as ready for review April 1, 2022 00:32
@scottybollinger scottybollinger requested a review from a team April 1, 2022 00:32
@scottybollinger scottybollinger requested review from a team as code owners April 1, 2022 00:32
afharo
afharo approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry changes LGTM

@scottybollinger
Copy link
Contributor Author

@elasticmachine merge upstream

@scottybollinger
Copy link
Contributor Author

@elastic/kibana-security may I please get a review on this?

@scottybollinger
Copy link
Contributor Author

@elasticmachine merge upstream

@scottybollinger scottybollinger removed the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 4, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1423 1449 +26

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.4MB 1.5MB +26.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
enterpriseSearch 19.9KB 20.6KB +713.0B
Unknown metric groups

async chunk count

id before after diff
enterpriseSearch 7 8 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

thomheymann
thomheymann approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@thomheymann thomheymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security changes LGTM!

@scottybollinger scottybollinger merged commit d69c993 into elastic:main Apr 4, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomheymann thomheymann thomheymann approved these changes

@efegurkan efegurkan efegurkan approved these changes

@afharo afharo afharo approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@scottybollinger @kibana-ci @thomheymann @efegurkan @afharo @kibanamachine