Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Remove gated Content plugin #128939

Merged
merged 1 commit into from
Mar 30, 2022
Merged

[Enterprise Search] Remove gated Content plugin #128939

merged 1 commit into from
Mar 30, 2022

Conversation

scottybollinger
Copy link
Contributor

@scottybollinger scottybollinger commented Mar 30, 2022 •
edited
Loading

Summary

When we added basic scaffolding for the Content plugin, we added a gated plugin for development. This had unintended consequences on FTR in other apps. This PR reverts this commit.

Will reintroduce in 8.3 ungated.

Slack thread for context.

@scottybollinger scottybollinger added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 Team:EnterpriseSearch labels Mar 30, 2022
@scottybollinger scottybollinger requested a review from a team March 30, 2022 16:08
@scottybollinger scottybollinger added the bug Fixes for quality problems that affect the customer experience label Mar 30, 2022
@scottybollinger scottybollinger enabled auto-merge (squash) March 30, 2022 16:38
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@scottybollinger scottybollinger merged commit b080a4f into elastic:main Mar 30, 2022
@kibanamachine
Copy link
Contributor

⚪ Backport skipped

The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.

Manual backport

To create the backport manually run:

node scripts/backport --pr 128939

Questions ?

Please refer to the Backport tool documentation

@scottybollinger scottybollinger mentioned this pull request Mar 31, 2022
Merged
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128939 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 1, 2022
@spalger spalger added auto-backport Deprecated - use backport:version if exact versions are needed and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 1, 2022
@kibanamachine
Copy link
Contributor

⚪ Backport skipped

The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.

Manual backport

To create the backport manually run:

node scripts/backport --pr 128939

Questions ?

Please refer to the Backport tool documentation

@spalger spalger added the backport:skip This commit does not require backporting label Apr 1, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 1, 2022
@spalger spalger removed the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efegurkan efegurkan efegurkan approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@scottybollinger @kibana-ci @kibanamachine @efegurkan @spalger