Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip add runtime field test #118303

Merged
merged 4 commits into from
Nov 11, 2021
Merged

Unskip add runtime field test #118303

merged 4 commits into from
Nov 11, 2021

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Nov 11, 2021 •
edited
Loading

Summary

close #95376

50 successful runs: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/204

Probably we can also unskip #107854 with similar changes cc @flash1293 @sebelga

@Dosant Dosant changed the title D/2021 11 11 unskip runtime field test Unskip add runtime field test Nov 11, 2021
@Dosant Dosant added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:AppServicesSv v8.0.0 v8.1.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.16.1 and removed backport:skip This commit does not require backporting labels Nov 11, 2021
@flash1293
Copy link
Contributor

Thanks for the ping - the Lens tests never got skipped, but I will keep an eye open for it.

@Dosant Dosant marked this pull request as ready for review November 11, 2021 13:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@Dosant Dosant requested review from mattkime and a team November 11, 2021 13:33
@Dosant Dosant removed v8.0.0 v7.16.1 auto-backport Deprecated - use backport:version if exact versions are needed labels Nov 11, 2021
mattkime
mattkime approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, thanks for taking are of this!

@Dosant
Merge branch 'main' of github.com:elastic/kibana into d/2021-11-11-un…
5a79124 
…skip-runtime-field-test

# Conflicts:
#	test/functional/services/monaco_editor.ts
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default Accessibility Tests / ml for user with full ML access with data loaded data frame analytics outlier job exploration page

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit a906706 into elastic:main Nov 11, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 15, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 118303 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 15, 2021
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
@Dosant @dmlemeshko
Unskip add runtime field test (#118303)
1901da9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkime mattkime mattkime approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.1.0
Projects
None yet
Milestone
No milestone
5 participants
@Dosant @flash1293 @elasticmachine @kibanamachine @mattkime