Unskip add runtime field test (#118303)

elastic · Nov 11, 2021 · a906706 · a906706
1 parent 553db0b
commit a906706
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 21 deletions.
diff --git a/test/functional/apps/management/_runtime_fields.js b/test/functional/apps/management/_runtime_fields.js
@@ -16,8 +16,7 @@ export default function ({ getService, getPageObjects }) {
   const PageObjects = getPageObjects(['settings']);
   const testSubjects = getService('testSubjects');
 
-  // FLAKY: https://github.com/elastic/kibana/issues/95376
-  describe.skip('runtime fields', function () {
+  describe('runtime fields', function () {
     this.tags(['skipFirefox']);
 
     before(async function () {
@@ -60,7 +59,7 @@ export default function ({ getService, getPageObjects }) {
         await PageObjects.settings.filterField(fieldName);
         await testSubjects.click('editFieldFormat');
         await PageObjects.settings.setFieldType('Long');
-        await PageObjects.settings.changeFieldScript('emit(6);');
+        await PageObjects.settings.setFieldScript('emit(6);');
         await testSubjects.find('changeWarning');
         await PageObjects.settings.clickSaveField();
         await PageObjects.settings.confirmSave();

diff --git a/test/functional/page_objects/settings_page.ts b/test/functional/page_objects/settings_page.ts
@@ -628,23 +628,9 @@ export class SettingsPageObject extends FtrService {
 
   async setFieldScript(script: string) {
     this.log.debug('set script = ' + script);
-    const valueRow = await this.toggleRow('valueRow');
-    const getMonacoTextArea = async () => (await valueRow.findAllByCssSelector('textarea'))[0];
-    this.retry.waitFor('monaco editor is ready', async () => !!(await getMonacoTextArea()));
-    const monacoTextArea = await getMonacoTextArea();
-    await monacoTextArea.focus();
-    this.browser.pressKeys(script);
-  }
-
-  async changeFieldScript(script: string) {
-    this.log.debug('set script = ' + script);
-    const valueRow = await this.testSubjects.find('valueRow');
-    const getMonacoTextArea = async () => (await valueRow.findAllByCssSelector('textarea'))[0];
-    this.retry.waitFor('monaco editor is ready', async () => !!(await getMonacoTextArea()));
-    const monacoTextArea = await getMonacoTextArea();
-    await monacoTextArea.focus();
-    this.browser.pressKeys(this.browser.keys.DELETE.repeat(30));
-    this.browser.pressKeys(script);
+    await this.toggleRow('valueRow');
+    await this.monacoEditor.waitCodeEditorReady('valueRow');
+    await this.monacoEditor.setCodeEditorValue(script);
   }
 
   async clickAddScriptedField() {

diff --git a/test/functional/services/monaco_editor.ts b/test/functional/services/monaco_editor.ts
@@ -13,6 +13,11 @@ export class MonacoEditorService extends FtrService {
   private readonly browser = this.ctx.getService('browser');
   private readonly testSubjects = this.ctx.getService('testSubjects');
 
+  public async waitCodeEditorReady(containerTestSubjId: string) {
+    const editorContainer = await this.testSubjects.find(containerTestSubjId);
+    await editorContainer.findByCssSelector('textarea');
+  }
+
   public async getCodeEditorValue(nthIndex: number = 0) {
     let values: string[] = [];
 
@@ -31,7 +36,6 @@ export class MonacoEditorService extends FtrService {
   public async typeCodeEditorValue(value: string, testSubjId: string) {
     const editor = await this.testSubjects.find(testSubjId);
     const textarea = await editor.findByCssSelector('textarea');
-
     await textarea.type(value);
   }