-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Make Dashboard Saved Objects multiple-isolated #115817
Conversation
Pinging @elastic/kibana-presentation (Team:Presentation) |
Similar to #114408 (comment) and #114620 (comment), I expect this change will make Spaces API integration tests fail. If/when that happens I can push changes to this PR to fix them. I'll let it complete a full CI run before I do that, though. |
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / general / API Integration Tests.test/api_integration/apis/saved_objects_management/find·ts.apis saved objects management apis find meta attributes injected properly should inject meta attributes for dashboardsStandard Out
Stack Trace
Kibana Pipeline / general / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/update_actions·ts.detection engine api security and spaces enabled update_actions updating actions should be able to create a new webhook action and attach it to a rule without a meta field and run it correctlyStandard Out
Stack Trace
Kibana Pipeline / general / X-Pack Spaces API Integration Tests -- security_and_spaces.x-pack/test/spaces_api_integration/security_and_spaces/apis/copy_to_space·ts.spaces api with security copy to spaces superuser from the default space single-namespace types should return 200 when copying to space without conflicts or referencesStandard Out
Stack Trace
and 2 more failures, only showing the first 3. Metrics [docs]
To update your PR or re-run it, just comment with: |
Will plan to fix these this afternoon. Shouldn't be too tough! |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security/Spaces test changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presentation team changes LGTM!
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Changes Dashboard saved objects to be multiple-isolated