Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualizations] Make visualization saved object share-capable and remove savedVisLoader #114620

Conversation

VladLasitsa
Copy link
Contributor

@VladLasitsa VladLasitsa requested a review from flash1293 October 12, 2021 12:06
@VladLasitsa VladLasitsa self-assigned this Oct 12, 2021
@VladLasitsa VladLasitsa added release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 labels Oct 12, 2021
@jportner
Copy link
Contributor

Similar to #114408 (comment), the Spaces API integration tests are failing because they use test fixtures for pre-8.0 visualizations, but they skip the index migration process. I can update the test data accordingly, I'll push a commit to this PR to do so.

@jportner jportner self-requested a review October 12, 2021 18:37
@jportner
Copy link
Contributor

The last API integration tests (for upsert) are failing because of a bug, this PR will be unblocked by #114929

@jportner
Copy link
Contributor

@elasticmachine merge upstream

@VladLasitsa VladLasitsa marked this pull request as ready for review October 15, 2021 14:14
@VladLasitsa VladLasitsa requested review from a team as code owners October 15, 2021 14:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Spaces test changes that I made LGTM, obviously 😄

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visualizations 108 104 -4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
visualizations 286 285 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualizations 72.8KB 72.8KB -3.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
visualizations 16 15 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visualizations 38.8KB 36.1KB -2.7KB
Unknown metric groups

API count

id before after diff
visualizations 304 303 -1

References to deprecated APIs

id before after diff
visualizations 100 81 -19

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected, LGTM

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 20, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 114620 or prevent reminders by adding the backport:skip label.

@jportner jportner added the backport:skip This commit does not require backporting label Oct 20, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants