-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Visualizations] Make visualization saved object share-capable and remove savedVisLoader #114620
[Visualizations] Make visualization saved object share-capable and remove savedVisLoader #114620
Conversation
Similar to #114408 (comment), the Spaces API integration tests are failing because they use test fixtures for pre-8.0 visualizations, but they skip the index migration process. I can update the test data accordingly, I'll push a commit to this PR to do so. |
The last API integration tests (for upsert) are failing because of a bug, this PR will be unblocked by #114929 |
@elasticmachine merge upstream |
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Spaces test changes that I made LGTM, obviously 😄
…ed_object_share_capable
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @VladLasitsa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works as expected, LGTM
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Summary
Removed old savedVisLoader completely and did
Step 4 of https://www.elastic.co/guide/en/kibana/master/sharing-saved-objects.html#sharing-saved-objects-step-4