Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add link to integration data retention documentation #115353

Merged

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Oct 18, 2021

Summary

Closes #110342.

Add some help text for customising integration data retention with a link to the new documentation.

Screenshot 2021-10-18 at 13 12 47

@hop-dev hop-dev added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 18, 2021
@hop-dev hop-dev self-assigned this Oct 18, 2021
@hop-dev hop-dev force-pushed the 110342-integration-data-retention-link branch from d19c111 to 7da90e4 Compare October 19, 2021 09:29
@hop-dev hop-dev marked this pull request as ready for review October 19, 2021 09:30
@hop-dev hop-dev requested review from a team as code owners October 19, 2021 09:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 19, 2021

💔 Build Failed

Failed CI Steps


Test Failures

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security/public/management/users/edit_user.EditUserPage changes password of current user when submitting form and closes dialog

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: thrown: "Exceeded timeout of 5000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.test.tsx:252:3
    at _dispatchDescribe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/index.js:67:26)
    at describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/index.js:30:5)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.test.tsx:37:1)
    at Runtime._execModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:1299:24)
    at Runtime._loadModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:898:12)
    at Runtime.requireModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:746:10)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:106:13)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security/public/management/users/edit_user.EditUserPage validates change password form

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/115474


Stack Trace

Error: thrown: "Exceeded timeout of 5000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.test.tsx:328:3
    at _dispatchDescribe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/index.js:67:26)
    at describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/index.js:30:5)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.test.tsx:37:1)
    at Runtime._execModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:1299:24)
    at Runtime._loadModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:898:12)
    at Runtime.requireModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:746:10)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:106:13)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security/public/management/users/edit_user.EditUserPage deactivates user when confirming and closes dialog

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

TestingLibraryElementError: Unable to find an accessible element with the role "dialog"

Here are the accessible roles:

  banner:

  Name "":
  <header
    class="euiPageHeader euiPageHeader--bottomBorder euiPageHeader--responsive euiPageHeader--center"
  />

  --------------------------------------------------
  heading:

  Name "jdoe jdoe":
  <h1
    class="euiTitle euiTitle--large"
  />

  Name "jdoe":
  <h1
    class="euiTitle euiTitle--medium"
  />

  Name "Profile":
  <h2
    class="euiTitle euiTitle--xsmall euiDescribedFormGroup__title"
  />

  Name "Privileges":
  <h2
    class="euiTitle euiTitle--xsmall euiDescribedFormGroup__title"
  />

  --------------------------------------------------
  group:

  Name "":
  <div
    class="euiDescribedFormGroup"
    role="group"
  />

  Name "":
  <div
    class="euiDescribedFormGroup"
    role="group"
  />

  --------------------------------------------------
  textbox:

  Name "Username":
  <input
    aria-describedby="id-0.531398031937949-help-0"
    class="euiFieldText euiFieldText--withIcon"
    data-test-subj="userFormUserNameInput"
    disabled=""
    id="id-0.531398031937949"
    name="username"
    type="text"
    value="jdoe"
  />

  Name "Full name":
  <input
    class="euiFieldText"
    data-test-subj="userFormFullNameInput"
    id="id-0.7982677734752266"
    name="full_name"
    type="text"
    value=""
  />

  Name "Email address":
  <input
    class="euiFieldText"
    data-test-subj="userFormEmailInput"
    id="id-0.32981885235828257"
    name="email"
    type="text"
    value=""
  />

  Name "Roles":
  <input
    aria-controls=""
    data-test-subj="comboBoxSearchInput"
    id="id-0.67875948081046"
    role="textbox"
    style="box-sizing: content-box; width: 2px;"
    value=""
  />

  --------------------------------------------------
  combobox:

  Name "":
  <div
    aria-expanded="false"
    aria-haspopup="listbox"
    class="euiComboBox"
    data-test-subj="rolesDropdown"
    role="combobox"
  />

  --------------------------------------------------
  button:

  Name "Remove superuser from selection in this group":
  <button
    aria-label="Remove superuser from selection in this group"
    class="euiBadge__iconButton"
    title="Remove superuser from selection in this group"
    type="button"
  />

  Name "Clear input":
  <button
    aria-label="Clear input"
    class="euiFormControlLayoutClearButton"
    data-test-subj="comboBoxClearButton"
    type="button"
  />

  Name "Open list of options":
  <button
    aria-label="Open list of options"
    class="euiFormControlLayoutCustomIcon euiFormControlLayoutCustomIcon--clickable"
    data-test-subj="comboBoxToggleListButton"
    type="button"
  />

  Name "Update user":
  <button
    class="euiButton euiButton--primary euiButton--fill"
    type="submit"
  />

  Name "Cancel":
  <button
    class="euiButtonEmpty euiButtonEmpty--primary euiButtonEmpty--flushLeft"
    type="button"
  />

  Name "Change password":
  <button
    class="euiButton euiButton--primary euiButton--small"
    type="button"
  />

  Name "Deactivate user":
  <button
    class="euiButton euiButton--primary euiButton--small"
    type="button"
  />

  Name "Delete user":
  <button
    class="euiButton euiButton--danger euiButton--small"
    type="button"
  />

  --------------------------------------------------
  link:

  Name "Learn what privileges individual roles grant. External link (opens in a new tab or window)":
  <a
    class="euiLink euiLink--primary"
    href="https://www.elastic.co/guide/en/elasticsearch/reference/mocked-test-branch/built-in-roles.html"
    rel="noopener"
    target="_blank"
  />

  --------------------------------------------------
  separator:

  Name "":
  <hr
    class="euiHorizontalRule euiHorizontalRule--full euiHorizontalRule--marginLarge"
  />

  --------------------------------------------------
  definition:

  Name "":
  <dd
    class="euiDescriptionList__description"
  />

  Name "":
  <dd
    class="euiDescriptionList__description"
  />

  Name "":
  <dd
    class="euiDescriptionList__description"
  />

  --------------------------------------------------

<body>
  <div>
    <header
      class="euiPageHeader euiPageHeader--bottomBorder euiPageHeader--responsive euiPageHeader--center"
    >
      <div
        class="euiPageHeaderContent"
      >
        <div
          class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--alignItemsFlexStart euiFlexGroup--directionRow euiFlexGroup--responsive euiPageHeaderContent__top"
        >
          <div
            class="euiFlexItem"
          >
            <h1
              class="euiTitle euiTitle--large"
            >
              <div
                class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--alignItemsCenter euiFlexGroup--directionRow"
              >
                <div
                  class="euiFlexItem euiFlexItem--flexGrowZero"
                >
                  <div
                    aria-label="jdoe"
                    class="euiAvatar euiAvatar--xl euiAvatar--user"
                    style="background-color: rgb(228, 166, 199); color: rgb(0, 0, 0);"
                    title="jdoe"
                  >
                    <span
                      aria-hidden="true"
                    >
                      j
                    </span>
                  </div>
                </div>
                <div
                  class="euiFlexItem"
                >
                  <h1
                    class="euiTitle euiTitle--medium"
                  >
                    jdoe
                  </h1>
                  <div
                    class="euiText euiText--medium"
                  />
                </div>
              </div>
            </h1>
          </div>
        </div>
      </div>
    </header>
    <div
      class="euiSpacer euiSpacer--l"
    />
    <form
      class="euiForm"
      novalidate=""
    >
      <div
        class="euiDescribedFormGroup"
        role="group"
      >
        <div
          class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--directionRow euiFlexGroup--responsive"
        >
          <div
            class="euiFlexItem"
          >
            <h2
              class="euiTitle euiTitle--xsmall euiDescribedFormGroup__title"
            >
              Profile
            </h2>
            <div
              class="euiText euiText--small euiDescribedFormGroup__description"
            >
              <div
                class="euiTextColor euiTextColor--subdued"
              >
                Provide personal details.
              </div>
            </div>
          </div>
          <div
            class="euiFlexItem euiDescribedFormGroup__fields euiDescribedFormGroup__fieldPadding--xsmall"
          >
            <div
              class="euiFormRow"
              id="id-0.531398031937949-row"
            >
              <div
                class="euiFormRow__labelWrapper"
              >
                <label
                  class="euiFormLabel euiFormRow__label"
                  for="id-0.531398031937949"
                >
                  Username
                </label>
              </div>
              <div
                class="euiFormRow__fieldWrapper"
              >
                <div
                  class="euiFormControlLayout"
                >
                  <div
                    class="euiFormControlLayout__childrenWrapper"
                  >
                    <input
                      aria-describedby="id-0.531398031937949-help-0"
                      class="euiFieldText euiFieldText--withIcon"
                      data-test-subj="userFormUserNameInput"
                      disabled=""
                      id="id-0.531398031937949"
                      name="username"
                      type="text"
                      value="jdoe"
                    />
                    <div
                      class="euiFormControlLayoutIcons"
                    >
                      <span
                        class="euiFormControlLayoutCustomIcon"
                      >
                        <span
                          aria-hidden="true"
                          class="euiFormControlLayoutCustomIcon__icon"
                          data-euiicon-type="user"
                        />
                      </span>
                    </div>
                  </div>
                </div>
                <div
                  class="euiFormHelpText euiFormRow__text"
                  id="id-0.531398031937949-help-0"
                >
                  Username can't be changed once created.
                </div>
              </div>
            </div>
            <div
              class="euiFormRow"
              id="id-0.7982677734752266-row"
            >
              <div
                class="euiFormRow__labelWrapper"
              >
                <label
                  class="euiFormLabel euiFormRow__label"
                  for="id-0.7982677734752266"
                >...
    at Object.getElementError (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/@testing-library/dom/dist/config.js:37:19)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/@testing-library/dom/dist/query-helpers.js:90:38
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/@testing-library/dom/dist/query-helpers.js:62:17
    at getByRole (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/@testing-library/dom/dist/query-helpers.js:111:19)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.test.tsx:389:20)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

and 1 more failures, only showing the first 3.

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 619.4KB 620.2KB +791.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 302.9KB 302.9KB +70.0B

History

  • 💔 Build #162008 failed d19c111ffd2bb655ca00bfa16287e0710cd87759

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@joshdover
Copy link
Contributor

@jen-huang How do you feel about merging this after FF? The reason being that we haven't decided on a URL yet for the doc link, but I don't want to merge a broken link in the UI.

I don't think there's any risk to merging this afterwards since it's such a contained change.

@jen-huang
Copy link
Contributor

++ from me for merging after FF, it is a low risk change.

@jen-huang jen-huang added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Oct 19, 2021
@@ -472,6 +472,7 @@ export class DocLinksService {
},
fleet: {
guide: `${FLEET_DOCS}index.html`,
customizeIntegrationDataRetention: `${FLEET_DOCS}customize-data-retention.html`, // TODO: this is a temp URL until we decide the correct one
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Is there an issue you could link to here for the TODO?

@joshdover
Copy link
Contributor

@hop-dev We can use this URL and go ahead and merge this: elastic/observability-docs#986 (comment)

@hop-dev hop-dev force-pushed the 110342-integration-data-retention-link branch from 7da90e4 to fe07ab5 Compare October 25, 2021 13:17
Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hop-dev hop-dev force-pushed the 110342-integration-data-retention-link branch from fe07ab5 to 9d5d2f9 Compare October 25, 2021 13:35
@hop-dev hop-dev force-pushed the 110342-integration-data-retention-link branch from 9d5d2f9 to 05ccd36 Compare October 25, 2021 15:11
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 621.3KB 622.0KB +772.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 307.0KB 307.0KB +56.0B

History

  • 💔 Build #1398 failed 9d5d2f9770f68189e7dded4219ceb2a6f548c2b4
  • 💔 Build #1387 failed fe07ab54aa345aeaa31f534000f0c1f729eaca23

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

@hop-dev hop-dev merged commit a266b2d into elastic:master Oct 25, 2021
@hop-dev hop-dev deleted the 110342-integration-data-retention-link branch October 25, 2021 18:54
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 25, 2021
…#115353)

* add ILM policy help text

* update API docs

* change link

* regen api docs
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.16

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 25, 2021
#116198)

* add ILM policy help text

* update API docs

* change link

* regen api docs

Co-authored-by: Mark Hopkin <[email protected]>
hop-dev added a commit to hop-dev/kibana that referenced this pull request Nov 18, 2021
hop-dev added a commit that referenced this pull request Nov 22, 2021
…115353)" (#119015)

* Revert "[Fleet] Add link to integration data retention documentation (#115353)"

This reverts commit a266b2d.

* remove unused translations

Co-authored-by: Kibana Machine <[email protected]>
hop-dev added a commit to hop-dev/kibana that referenced this pull request Nov 23, 2021
…lastic#115353)" (elastic#119015)

* Revert "[Fleet] Add link to integration data retention documentation (elastic#115353)"

This reverts commit a266b2d.

* remove unused translations

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	docs/development/core/public/kibana-plugin-core-public.doclinksstart.md
hop-dev added a commit that referenced this pull request Nov 23, 2021
…115353)" (#119015) (#119436)

* Revert "[Fleet] Add link to integration data retention documentation (#115353)"

This reverts commit a266b2d.

* remove unused translations

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	docs/development/core/public/kibana-plugin-core-public.doclinksstart.md
hop-dev added a commit that referenced this pull request Nov 23, 2021
…115353)" (#119015) (#119438)

* Revert "[Fleet] Add link to integration data retention documentation (#115353)"

This reverts commit a266b2d.

* remove unused translations

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	docs/development/core/public/kibana-plugin-core-public.doclinksstart.md
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
…115353)" (#119015)

* Revert "[Fleet] Add link to integration data retention documentation (#115353)"

This reverts commit a266b2d.

* remove unused translations

Co-authored-by: Kibana Machine <[email protected]>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
…lastic#115353)" (elastic#119015)

* Revert "[Fleet] Add link to integration data retention documentation (elastic#115353)"

This reverts commit a266b2d.

* remove unused translations

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Link to documentation on how to set data retention/ILM policies
8 participants