-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Add link to integration data retention documentation #115353
[Fleet] Add link to integration data retention documentation #115353
Conversation
d19c111
to
7da90e4
Compare
Pinging @elastic/fleet (Team:Fleet) |
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / jest / Jest Tests.x-pack/plugins/security/public/management/users/edit_user.EditUserPage changes password of current user when submitting form and closes dialogStandard Out
Stack Trace
Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security/public/management/users/edit_user.EditUserPage validates change password formStandard Out
Stack Trace
Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security/public/management/users/edit_user.EditUserPage deactivates user when confirming and closes dialogStandard Out
Stack Trace
and 1 more failures, only showing the first 3. Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @hop-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@jen-huang How do you feel about merging this after FF? The reason being that we haven't decided on a URL yet for the doc link, but I don't want to merge a broken link in the UI. I don't think there's any risk to merging this afterwards since it's such a contained change. |
++ from me for merging after FF, it is a low risk change. |
@@ -472,6 +472,7 @@ export class DocLinksService { | |||
}, | |||
fleet: { | |||
guide: `${FLEET_DOCS}index.html`, | |||
customizeIntegrationDataRetention: `${FLEET_DOCS}customize-data-retention.html`, // TODO: this is a temp URL until we decide the correct one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Is there an issue you could link to here for the TODO?
@hop-dev We can use this URL and go ahead and merge this: elastic/observability-docs#986 (comment) |
7da90e4
to
fe07ab5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
fe07ab5
to
9d5d2f9
Compare
9d5d2f9
to
05ccd36
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @hop-dev |
…#115353) * add ILM policy help text * update API docs * change link * regen api docs
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
#116198) * add ILM policy help text * update API docs * change link * regen api docs Co-authored-by: Mark Hopkin <[email protected]>
…lastic#115353)" This reverts commit a266b2d.
…115353)" (#119015) * Revert "[Fleet] Add link to integration data retention documentation (#115353)" This reverts commit a266b2d. * remove unused translations Co-authored-by: Kibana Machine <[email protected]>
…lastic#115353)" (elastic#119015) * Revert "[Fleet] Add link to integration data retention documentation (elastic#115353)" This reverts commit a266b2d. * remove unused translations Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # docs/development/core/public/kibana-plugin-core-public.doclinksstart.md
…115353)" (#119015) (#119436) * Revert "[Fleet] Add link to integration data retention documentation (#115353)" This reverts commit a266b2d. * remove unused translations Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # docs/development/core/public/kibana-plugin-core-public.doclinksstart.md
…115353)" (#119015) (#119438) * Revert "[Fleet] Add link to integration data retention documentation (#115353)" This reverts commit a266b2d. * remove unused translations Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # docs/development/core/public/kibana-plugin-core-public.doclinksstart.md
…115353)" (#119015) * Revert "[Fleet] Add link to integration data retention documentation (#115353)" This reverts commit a266b2d. * remove unused translations Co-authored-by: Kibana Machine <[email protected]>
…lastic#115353)" (elastic#119015) * Revert "[Fleet] Add link to integration data retention documentation (elastic#115353)" This reverts commit a266b2d. * remove unused translations Co-authored-by: Kibana Machine <[email protected]>
Summary
Closes #110342.
Add some help text for customising integration data retention with a link to the new documentation.