[DataTable] Add rowHeightsOptions to table #114637

VladLasitsa · 2021-10-12T13:57:02Z

Summary

Closes #109382
Closes #98257
Closes #81210

Adds a new option to the table Options tab to auto-fit the content to the row.

This solves the problem of rendering data that do not fit in one row or the rendering of images.

Current mock was failing due to missing useGeneratedHtmlId export. This is safe to remove because EUI contains a .testenv that contains an mock for html_id_generator. More info at https://github.com/elastic/eui/blob/master/src/services/accessibility/html_id_generator.testenv.ts

Current mock was failing due to missing useGeneratedHtmlId export. This is safe to remove because EUI contains a .testenv that contains a mock for html_id_generator. More info at https://github.com/elastic/eui/blob/master/src/services/accessibility/html_id_generator.testenv.ts

…onflict in availability_reporting.test.tsx

…pgrade-38.2.0 Merging in the latest code from the Master branch

…ndle an issue found with a functional test during the original upgrade

… addition in EUI v. 39.0.0

…pgrade-38.2.0 Merging in the latest code from the Master branch

Removing TODO comments from src/dev/license_checker/config.ts as they are no longer needed. Co-authored-by: Constance <[email protected]>

stratoula · 2021-10-13T12:53:26Z

@elasticmachine merge upstream

kibanamachine · 2021-10-13T12:53:28Z

merge conflict between base and head

…atatable

flash1293 · 2021-10-13T15:22:58Z

@elasticmachine merge upstream

stratoula · 2021-10-15T09:40:06Z

Yes sounds fine for now, can you push it in order to test how it works ?

VladLasitsa · 2021-10-15T10:14:41Z

Yes sounds fine for now, can you push it in order to test how it works ?

Sorry found the same problem when clicking on refresh button in kibana. It can take more time.

…g data or setting

VladLasitsa · 2021-10-15T17:50:47Z

@elasticmachine merge upstream

flash1293 · 2021-10-18T07:02:48Z

@elasticmachine merge upstream

flash1293 · 2021-10-18T08:43:33Z

src/plugins/vis_types/table/public/components/table_vis_basic.tsx

@@ -129,6 +129,7 @@ export const TableVisBasic = memo(
      }
      // update counter to remount grid from scratch
      setDataGridUpdateCounter(dataGridUpdateCounter + 1);


I think it should be fixed like this instead, not sure whether the linting thing will work in all cases:

setDataGridUpdateCounter((i) => i + 1);

flash1293 · 2021-10-18T09:28:57Z

With the change mentioned above (#114637 (comment)), I think this workaround is viable. There is a noticeable flicker, but IMHO that's OK as it just happens as long as the setting is enabled (which shouldn't be the common case):
auto-height

regular

I added a mention of this new setting to the breaking change release note to make sure people relying on this setting at the moment know how to migrate: #111339

One thing that doesn't work right yet - if the client side sorting is used, it breaks in weird ways. I guess we need to add the sorting settings to the dependency list of the update counter hook:

flash1293 · 2021-10-18T11:44:20Z

@VladLasitsa the unit test looks like it’s caused by the changes but I think the rest is caused by some CI problem

stratoula · 2021-10-18T13:21:11Z

Yes as Joe said, pagination is also broken

and also the column resize, although for text seems to work fine, for images it doesn't

I made other tests, remove/add/hide columns, show total, they seem to work fine

flash1293 · 2021-10-18T13:24:50Z

Good catch @stratoula , I only tested text with the resize. Let’s add resize options and pagination as well

VladLasitsa · 2021-10-18T13:33:23Z

Good catch @stratoula , I only tested text with the resize. Let’s add resize options and pagination as well

Added

stratoula

LGTM, I tested it locally and I think that it works as expected. I think that it is fine for now until the bug is fixed in EUI side.

flash1293 · 2021-10-18T15:38:38Z

@elasticmachine merge upstream

flash1293 · 2021-10-18T16:29:53Z

@elasticmachine merge upstream

kibanamachine · 2021-10-18T17:55:16Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 4f5ceec
Storybooks Preview
Flaky suites:
- xpack-kibana-ciGroup6

Test Failures

Kibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/ml/jobs/categorization_field_examples·ts.apis Machine Learning jobs Categorization example endpoint - partially valid, more than 75% are null

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]     │
[00:00:00]       └-: apis
[00:00:00]         └-> "before all" hook in "apis"
[00:10:36]         └-: Machine Learning
[00:10:36]           └-> "before all" hook in "Machine Learning"
[00:10:36]           └-> "before all" hook in "Machine Learning"
[00:10:36]             │ debg creating role ft_ml_source
[00:10:36]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_source]
[00:10:36]             │ debg creating role ft_ml_source_readonly
[00:10:36]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_source_readonly]
[00:10:36]             │ debg creating role ft_ml_dest
[00:10:36]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_dest]
[00:10:36]             │ debg creating role ft_ml_dest_readonly
[00:10:36]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_dest_readonly]
[00:10:36]             │ debg creating role ft_ml_ui_extras
[00:10:36]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_ui_extras]
[00:10:36]             │ debg creating role ft_default_space_ml_all
[00:10:36]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_all]
[00:10:36]             │ debg creating role ft_default_space1_ml_all
[00:10:36]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space1_ml_all]
[00:10:36]             │ debg creating role ft_all_spaces_ml_all
[00:10:36]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_all_spaces_ml_all]
[00:10:36]             │ debg creating role ft_default_space_ml_read
[00:10:36]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_read]
[00:10:36]             │ debg creating role ft_default_space1_ml_read
[00:10:36]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space1_ml_read]
[00:10:36]             │ debg creating role ft_all_spaces_ml_read
[00:10:36]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_all_spaces_ml_read]
[00:10:36]             │ debg creating role ft_default_space_ml_none
[00:10:36]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_none]
[00:10:36]             │ debg creating user ft_ml_poweruser
[00:10:36]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser]
[00:10:36]             │ debg created user ft_ml_poweruser
[00:10:36]             │ debg creating user ft_ml_poweruser_spaces
[00:10:36]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_spaces]
[00:10:36]             │ debg created user ft_ml_poweruser_spaces
[00:10:36]             │ debg creating user ft_ml_poweruser_space1
[00:10:36]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_space1]
[00:10:36]             │ debg created user ft_ml_poweruser_space1
[00:10:36]             │ debg creating user ft_ml_poweruser_all_spaces
[00:10:36]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_all_spaces]
[00:10:36]             │ debg created user ft_ml_poweruser_all_spaces
[00:10:36]             │ debg creating user ft_ml_viewer
[00:10:37]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer]
[00:10:37]             │ debg created user ft_ml_viewer
[00:10:37]             │ debg creating user ft_ml_viewer_spaces
[00:10:37]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_spaces]
[00:10:37]             │ debg created user ft_ml_viewer_spaces
[00:10:37]             │ debg creating user ft_ml_viewer_space1
[00:10:37]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_space1]
[00:10:37]             │ debg created user ft_ml_viewer_space1
[00:10:37]             │ debg creating user ft_ml_viewer_all_spaces
[00:10:37]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_all_spaces]
[00:10:37]             │ debg created user ft_ml_viewer_all_spaces
[00:10:37]             │ debg creating user ft_ml_unauthorized
[00:10:37]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_unauthorized]
[00:10:37]             │ debg created user ft_ml_unauthorized
[00:10:37]             │ debg creating user ft_ml_unauthorized_spaces
[00:10:37]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_unauthorized_spaces]
[00:10:37]             │ debg created user ft_ml_unauthorized_spaces
[00:14:38]           └-: jobs
[00:14:38]             └-> "before all" hook in "jobs"
[00:14:38]             └-: Categorization example endpoint - 
[00:14:38]               └-> "before all" hook for "valid with good number of tokens"
[00:14:38]               └-> "before all" hook for "valid with good number of tokens"
[00:14:38]                 │ info [x-pack/test/functional/es_archives/ml/categorization] Loading "mappings.json"
[00:14:38]                 │ info [x-pack/test/functional/es_archives/ml/categorization] Loading "data.json.gz"
[00:14:38]                 │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [ft_categorization] creating index, cause [api], templates [], shards [1]/[0]
[00:14:38]                 │ info [x-pack/test/functional/es_archives/ml/categorization] Created index "ft_categorization"
[00:14:38]                 │ debg [x-pack/test/functional/es_archives/ml/categorization] "ft_categorization" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:14:39]                 │ info [x-pack/test/functional/es_archives/ml/categorization] Indexed 1501 docs into "ft_categorization"
[00:14:39]                 │ debg applying update to kibana config: {"dateFormat:tz":"UTC"}
[00:14:39]               └-> valid with good number of tokens
[00:14:39]                 └-> "before each" hook: global before each for "valid with good number of tokens"
[00:14:39]                 └- ✓ pass  (181ms)
[00:14:39]               └-> invalid, too many tokens.
[00:14:39]                 └-> "before each" hook: global before each for "invalid, too many tokens."
[00:14:39]                 │ info [r.suppressed] [node-01] path: /_analyze, params: {}
[00:14:39]                 │      org.elasticsearch.transport.RemoteTransportException: [node-01][127.0.0.1:63121][indices:admin/analyze[s]]
[00:14:39]                 │      Caused by: java.lang.IllegalStateException: The number of tokens produced by calling _analyze has exceeded the allowed maximum of [10000]. This limit can be set by changing the [index.analyze.max_token_count] index level setting.
[00:14:39]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction$TokenCounter.increment(TransportAnalyzeAction.java:397) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.simpleAnalyze(TransportAnalyzeAction.java:229) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.analyze(TransportAnalyzeAction.java:204) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.analyze(TransportAnalyzeAction.java:122) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.shardOperation(TransportAnalyzeAction.java:110) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.shardOperation(TransportAnalyzeAction.java:62) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction.lambda$asyncShardOperation$0(TransportSingleShardAction.java:99) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at org.elasticsearch.action.ActionRunnable.lambda$supply$0(ActionRunnable.java:47) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at org.elasticsearch.action.ActionRunnable$2.doRun(ActionRunnable.java:62) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:737) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:26) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?]
[00:14:39]                 │      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
[00:14:39]                 │      	at java.lang.Thread.run(Thread.java:833) [?:?]
[00:14:39]                 │ info [r.suppressed] [node-01] path: /_analyze, params: {}
[00:14:39]                 │      org.elasticsearch.transport.RemoteTransportException: [node-01][127.0.0.1:63121][indices:admin/analyze[s]]
[00:14:39]                 │      Caused by: java.lang.IllegalStateException: The number of tokens produced by calling _analyze has exceeded the allowed maximum of [10000]. This limit can be set by changing the [index.analyze.max_token_count] index level setting.
[00:14:39]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction$TokenCounter.increment(TransportAnalyzeAction.java:397) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.simpleAnalyze(TransportAnalyzeAction.java:229) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.analyze(TransportAnalyzeAction.java:204) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.analyze(TransportAnalyzeAction.java:122) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.shardOperation(TransportAnalyzeAction.java:110) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.shardOperation(TransportAnalyzeAction.java:62) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction.lambda$asyncShardOperation$0(TransportSingleShardAction.java:99) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at org.elasticsearch.action.ActionRunnable.lambda$supply$0(ActionRunnable.java:47) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at org.elasticsearch.action.ActionRunnable$2.doRun(ActionRunnable.java:62) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:737) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:26) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:14:39]                 │      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?]
[00:14:39]                 │      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
[00:14:39]                 │      	at java.lang.Thread.run(Thread.java:833) [?:?]
[00:14:40]                 └- ✓ pass  (209ms)
[00:14:40]               └-> partially valid, more than 75% are null
[00:14:40]                 └-> "before each" hook: global before each for "partially valid, more than 75% are null"
[00:14:40]                 └- ✖ fail: apis Machine Learning jobs Categorization example endpoint -  partially valid, more than 75% are null
[00:14:40]                 │       Error: expected 249 to sort of equal 250
[00:14:40]                 │       + expected - actual
[00:14:40]                 │ 
[00:14:40]                 │       -249
[00:14:40]                 │       +250
[00:14:40]                 │       
[00:14:40]                 │       at Assertion.assert (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:14:40]                 │       at Assertion.eql (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/expect/expect.js:244:8)
[00:14:40]                 │       at Context.<anonymous> (test/api_integration/apis/ml/jobs/categorization_field_examples.ts:303:36)
[00:14:40]                 │       at runMicrotasks (<anonymous>)
[00:14:40]                 │       at processTicksAndRejections (node:internal/process/task_queues:96:5)
[00:14:40]                 │       at Object.apply (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:14:40]                 │ 
[00:14:40]                 │

Stack Trace

Error: expected 249 to sort of equal 250
    at Assertion.assert (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/expect/expect.js:244:8)
    at Context.<anonymous> (test/api_integration/apis/ml/jobs/categorization_field_examples.ts:303:36)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Object.apply (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16) {
  actual: '249',
  expected: '250',
  showDiff: true
}

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`visTypeTable`	11	12	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`visTypeTable`	17.5KB	18.1KB	+601.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`visTypeTable`	14.7KB	14.8KB	+131.0B

Unknown metric groups

API count

id	before	after	diff
`visTypeTable`	11	12	+1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-10-18T18:42:51Z

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`visTypeTable`	11	12	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`visTypeTable`	17.5KB	18.1KB	+601.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`visTypeTable`	14.7KB	14.8KB	+131.0B

Unknown metric groups

API count

id	before	after	diff
`visTypeTable`	11	12	+1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Upgraded the version of EUI to 38.2.0 from 38.0.1 * Updated the i18n mappings required for EUI v.38.2.0 * Update i18n snapshots and resolve linting error * Removed html_id_generator mocks. Current mock was failing due to missing useGeneratedHtmlId export. This is safe to remove because EUI contains a .testenv that contains an mock for html_id_generator. More info at https://github.com/elastic/eui/blob/master/src/services/accessibility/html_id_generator.testenv.ts * Resolve linting error in i18n mapping file * Removed html_id_generator mocks. Current mock was failing due to missing useGeneratedHtmlId export. This is safe to remove because EUI contains a .testenv that contains a mock for html_id_generator. More info at https://github.com/elastic/eui/blob/master/src/services/accessibility/html_id_generator.testenv.ts * Update plugin snapshots * Resolve merge conflict in license_checker config.ts file * Upgrade EUI to version 39.0.0 from the original target (38.2.0) to handle an issue found with a functional test during the original upgrade * Updated the i18n mapping for EUI v.39.0.0 * Update various snapshots to account for the an i18n translation token addition in EUI v. 39.0.0 * Updated test cases marked as obsolete by CI * Update src/dev/license_checker/config.ts Removing TODO comments from src/dev/license_checker/config.ts as they are no longer needed. Co-authored-by: Constance <[email protected]> * Add option auto fit row to content * Fix tests * Fix tests * Add temp fix for correct rendering grid with auto-height when changing data or setting * Fix lint * Fix lint and tests * Adds new dependency for temp fix Co-authored-by: Brianna Hall <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Bree Hall <[email protected]> Co-authored-by: Constance <[email protected]>

kibanamachine · 2021-10-18T18:47:12Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* Upgraded the version of EUI to 38.2.0 from 38.0.1 * Updated the i18n mappings required for EUI v.38.2.0 * Update i18n snapshots and resolve linting error * Removed html_id_generator mocks. Current mock was failing due to missing useGeneratedHtmlId export. This is safe to remove because EUI contains a .testenv that contains an mock for html_id_generator. More info at https://github.com/elastic/eui/blob/master/src/services/accessibility/html_id_generator.testenv.ts * Resolve linting error in i18n mapping file * Removed html_id_generator mocks. Current mock was failing due to missing useGeneratedHtmlId export. This is safe to remove because EUI contains a .testenv that contains a mock for html_id_generator. More info at https://github.com/elastic/eui/blob/master/src/services/accessibility/html_id_generator.testenv.ts * Update plugin snapshots * Resolve merge conflict in license_checker config.ts file * Upgrade EUI to version 39.0.0 from the original target (38.2.0) to handle an issue found with a functional test during the original upgrade * Updated the i18n mapping for EUI v.39.0.0 * Update various snapshots to account for the an i18n translation token addition in EUI v. 39.0.0 * Updated test cases marked as obsolete by CI * Update src/dev/license_checker/config.ts Removing TODO comments from src/dev/license_checker/config.ts as they are no longer needed. Co-authored-by: Constance <[email protected]> * Add option auto fit row to content * Fix tests * Fix tests * Add temp fix for correct rendering grid with auto-height when changing data or setting * Fix lint * Fix lint and tests * Adds new dependency for temp fix Co-authored-by: Brianna Hall <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Bree Hall <[email protected]> Co-authored-by: Constance <[email protected]> Co-authored-by: Uladzislau Lasitsa <[email protected]> Co-authored-by: Brianna Hall <[email protected]> Co-authored-by: Bree Hall <[email protected]> Co-authored-by: Constance <[email protected]>

breehall and others added 23 commits October 1, 2021 10:25

Upgraded the version of EUI to 38.2.0 from 38.0.1

a298fb9

Updated the i18n mappings required for EUI v.38.2.0

69ee19c

Update i18n snapshots and resolve linting error

d44b789

Resolve linting error in i18n mapping file

1973fc9

Update plugin snapshots

ca1991e

Merging in the latest code from the master branch and resolve merge c…

eea8204

…onflict in availability_reporting.test.tsx

Resolve merge conflict in license_checker config.ts file

308c7ca

Merge branch 'master' of https://github.com/elastic/kibana into eui-u…

4380434

…pgrade-38.2.0 Merging in the latest code from the Master branch

Upgrade EUI to version 39.0.0 from the original target (38.2.0) to ha…

a9cf44b

…ndle an issue found with a functional test during the original upgrade

Updated the i18n mapping for EUI v.39.0.0

432b23f

Update various snapshots to account for the an i18n translation token…

fb88b04

… addition in EUI v. 39.0.0

Updated test cases marked as obsolete by CI

71233e5

Merge branch 'master' of https://github.com/elastic/kibana into eui-u…

f6833eb

…pgrade-38.2.0 Merging in the latest code from the Master branch

Merge branch 'master' into eui-upgrade-38.2.0

6a940f5

Update src/dev/license_checker/config.ts

379acdd

Removing TODO comments from src/dev/license_checker/config.ts as they are no longer needed. Co-authored-by: Constance <[email protected]>

Merge branch 'master' into eui-upgrade-38.2.0

54726ea

Merge branch 'master' into eui-upgrade-38.2.0

dd4ccbb

Merge branch 'master' into eui-upgrade-38.2.0

d13120a

Merge branch 'master' into eui-upgrade-38.2.0

f2394b2

Merge branch 'master' into eui-upgrade-38.2.0

a291847

Add option auto fit row to content

d515009

Merge remote-tracking branch 'upstream/master' into auto_height_for_d…

ccf5c7e

…atatable

kibanamachine and others added 2 commits October 13, 2021 11:23

Merge branch 'master' into auto_height_for_datatable

16b7a32

Fix tests

ffe37bb

flash1293 marked this pull request as ready for review October 14, 2021 15:37

Add temp fix for correct rendering grid with auto-height when changin…

18933fc

…g data or setting

Merge branch 'master' into auto_height_for_datatable

66be436

kibanamachine and others added 2 commits October 18, 2021 03:02

Merge branch 'master' into auto_height_for_datatable

e04a58f

Fix lint

c9f46dd

flash1293 reviewed Oct 18, 2021

View reviewed changes

Fix lint and tests

da34d0a

Adds new dependency for temp fix

449ba5f

stratoula approved these changes Oct 18, 2021

View reviewed changes

Merge branch 'master' into auto_height_for_datatable

4f5ceec

tylersmalley added the buildkite-ci label Oct 18, 2021

Merge branch 'master' into auto_height_for_datatable

d622ff1

VladLasitsa merged commit 8c3b433 into elastic:master Oct 18, 2021

kibanamachine mentioned this pull request Oct 18, 2021

[7.x] [DataTable] Add rowHeightsOptions to table (#114637) #115431

Merged

flash1293 mentioned this pull request Oct 20, 2021

Remove legacy data table #111339

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DataTable] Add rowHeightsOptions to table #114637

[DataTable] Add rowHeightsOptions to table #114637

VladLasitsa commented Oct 12, 2021 •

edited by stratoula

Loading

stratoula commented Oct 13, 2021

kibanamachine commented Oct 13, 2021

flash1293 commented Oct 13, 2021

stratoula commented Oct 15, 2021

VladLasitsa commented Oct 15, 2021

VladLasitsa commented Oct 15, 2021

flash1293 commented Oct 18, 2021

flash1293 Oct 18, 2021 •

edited

Loading

flash1293 commented Oct 18, 2021 •

edited

Loading

flash1293 commented Oct 18, 2021

stratoula commented Oct 18, 2021

flash1293 commented Oct 18, 2021

VladLasitsa commented Oct 18, 2021

stratoula left a comment •

edited

Loading

flash1293 commented Oct 18, 2021

flash1293 commented Oct 18, 2021

kibanamachine commented Oct 18, 2021

Standard Out

Stack Trace

API count

kibanamachine commented Oct 18, 2021

API count

kibanamachine commented Oct 18, 2021

[DataTable] Add rowHeightsOptions to table #114637

[DataTable] Add rowHeightsOptions to table #114637

Conversation

VladLasitsa commented Oct 12, 2021 • edited by stratoula Loading

Summary

stratoula commented Oct 13, 2021

kibanamachine commented Oct 13, 2021

flash1293 commented Oct 13, 2021

stratoula commented Oct 15, 2021

VladLasitsa commented Oct 15, 2021

VladLasitsa commented Oct 15, 2021

flash1293 commented Oct 18, 2021

flash1293 Oct 18, 2021 • edited Loading

Choose a reason for hiding this comment

flash1293 commented Oct 18, 2021 • edited Loading

flash1293 commented Oct 18, 2021

stratoula commented Oct 18, 2021

flash1293 commented Oct 18, 2021

VladLasitsa commented Oct 18, 2021

stratoula left a comment • edited Loading

Choose a reason for hiding this comment

flash1293 commented Oct 18, 2021

flash1293 commented Oct 18, 2021

kibanamachine commented Oct 18, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

History

kibanamachine commented Oct 18, 2021

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

kibanamachine commented Oct 18, 2021

💚 Backport successful

VladLasitsa commented Oct 12, 2021 •

edited by stratoula

Loading

flash1293 Oct 18, 2021 •

edited

Loading

flash1293 commented Oct 18, 2021 •

edited

Loading

stratoula left a comment •

edited

Loading