Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datatable] Remove the angular implementation #109382

Closed
stratoula opened this issue Aug 20, 2021 · 3 comments · Fixed by #114637
Closed

[Datatable] Remove the angular implementation #109382

stratoula opened this issue Aug 20, 2021 · 3 comments · Fixed by #114637
Assignees
Labels
Feature:Data Table Data table visualization feature Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0

Comments

@stratoula
Copy link
Contributor

We want to remove the old implementation of the legacy data table. The main reason for doing is the angular dependency. In 7.16 all kibana code that depends in Angular 1 should be either de-angularized or removed. We decided to remove the old datatable for the following reasons:

  • It is not the default solution from 7.11 (users can switch to it by changing their kibana.yml file vis_type_table.legacyVisEnabled: true)
  • The main blocker for keeping it is going to be fixed on EUI side. [EuiDataGrid] Auto-fit rows to content eui#4958
  • Our metrics show a very small amount of clusters that still operate with the legacy implementation (< 1%)

By removing this also this will be fixed #90582

Things that we need to do in order this issue to close:

  • Create a PR on the cloud repo to remove the whitelisted kibana.yml setting. Actually, revert the changes applied by this PR https://github.com/elastic/cloud/pull/72050
  • Removing the kibana.yml setting means that Kibana wouldn't start up after the upgrade (for the users that have configured it). I think that we should discuss with @KOTungseth how we need to address this removal in our docs
  • Clean up all the bugs that are open and have to do with the legacy datatable (and are solved by the new implementation)
  • Add an extra option to the new datable to let the users render their entire content (auto-height feature). [EuiDataGrid] Auto-fit rows to content eui#4958 should be merged first
@stratoula stratoula added Feature:Data Table Data table visualization feature Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 labels Aug 20, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor

@stratoula seems like this is done, right?

@stratoula
Copy link
Contributor Author

stratoula commented Sep 20, 2021

I haven't closed it yet because we haven't met this criteria

Add an extra option to the new datable to let the users render their entire content (auto-height feature). [EuiDataGrid] Auto-fit rows to content eui#4958 should be merged first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Table Data table visualization feature Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants