-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting][Docs] Combine rule creation and management pages #101498
Conversation
. <<defining-alerts-actions-details, Action type and action details>> | ||
|
||
image::images/rule-flyout-sections.png[The three sections of a rule definition] | ||
This content has been moved to <<create-and-manage-rules>>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to leave this file and anchor link here temporarily to avoid bad cross-document link errors. When this PR is merged, I will create PRs in the obs and ML docs repos to update links in their docs, and then I will make another PR to clean up these placeholders.
@@ -1,7 +1,7 @@ | |||
include::alerting-getting-started.asciidoc[] | |||
include::create-and-manage-rules.asciidoc[] | |||
include::defining-rules.asciidoc[] | |||
include::rule-management.asciidoc[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above: will remove links to defining-rules
and rule-management
when bad cross document links are resolved.
=== Required permissions | ||
|
||
Access to rules is granted based on your privileges to alerting-enabled features. See <<alerting-security, Alerting Security>> for more information. | ||
This content has been moved to <<create-and-manage-rules>>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above about cross document links.
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: gchaps <[email protected]>
…ing/restructure-docs-3
Co-authored-by: gchaps <[email protected]>
…ing/restructure-docs-3
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Some minor suggestions.
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @ymao1 |
…101498) * Combining rule management stuff into single page * Cleaning up image widths and header sizes * Adding in placeholder pages * Adding in placeholder pages * Apply suggestions from code review Co-authored-by: gchaps <[email protected]> * PR and test fixes * Apply suggestions from code review Co-authored-by: gchaps <[email protected]> * PR fixes * PR fixes Co-authored-by: gchaps <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…#101979) * Combining rule management stuff into single page * Cleaning up image widths and header sizes * Adding in placeholder pages * Adding in placeholder pages * Apply suggestions from code review Co-authored-by: gchaps <[email protected]> * PR and test fixes * Apply suggestions from code review Co-authored-by: gchaps <[email protected]> * PR fixes * PR fixes Co-authored-by: gchaps <[email protected]> Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # docs/user/monitoring/kibana-alerts.asciidoc
* master: (68 commits) skip flaky suite (elastic#94043) skip flaky suite (elastic#102012) [esArchive] Persists updates for management/saved_objects/* (elastic#101992) skip flaky suite (elastic#101449) remove unnecessary hack (elastic#101909) [Exploratory View] Use human readable formats (elastic#101520) [Expressions] Refactor expression functions to use observables underneath (elastic#100409) [esArchives] Persist migrated Kibana archives (elastic#101950) [kbnArchiver] fix save to non-existent file (elastic#101974) [Enterprise Search] Add owner and description properties to kibana.json (elastic#101957) [DOCS] Fixes terminology in Stack Monitoring:Kibana alerts (elastic#101696) [Observability] [Cases] Cases in the observability app (elastic#101487) [Alerting][Docs] Combine rule creation and management pages (elastic#101498) temporarily disable build-buddy [Fleet] Fix fleet server collector in case settings are not set (elastic#101752) [Event Log] Populated rule.* ECS fields for alert events. (elastic#101132) [APM] Fleet support for merging input.config values with other nested properties in the policy input (elastic#101690) Add comments to some alerting plugin public API items (elastic#101551) [Alerting][Docs] Moving alerting setup to its own page (elastic#101323) remove uptime public API, it's not used. (elastic#101799) ...
Summary
1/3 PRs to address some alerting docs changes suggested by @gchaps. Summary of all proposed changes described here
This PR combines the Defining Rules/Managing Rules/Rule details pages into single Create and Manage Rules page.
Docs link: https://kibana_101498.docs-preview.app.elstc.co/guide/en/kibana/master/create-and-manage-rules.html