Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Update cross-document links to Kibana Alerting docs #74034

Merged
merged 3 commits into from
Jun 14, 2021
Merged

[Docs] Update cross-document links to Kibana Alerting docs #74034

merged 3 commits into from
Jun 14, 2021

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Jun 10, 2021 •
edited
Loading

Some recent PRs have moved around some of the alerting docs within the Kibana docs, so some of the links need to be updated.

Relevant PRs:

@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label Jun 10, 2021
@ymao1 ymao1 changed the title Updating cross-document links [Docs] Update cross-document links to Kibana Alerting docs Jun 14, 2021
@ymao1 ymao1 self-assigned this Jun 14, 2021
@ymao1 ymao1 marked this pull request as ready for review June 14, 2021 14:43
@ymao1 ymao1 requested review from lcawl and gchaps June 14, 2021 14:43
gchaps
gchaps reviewed Jun 14, 2021
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me.

There is a link in the second paragraph to "Alerting and Actions". Should that be changed to "Alerting"?

@ymao1
Copy link
Contributor Author

ymao1 commented Jun 14, 2021

The change looks good to me.

There is a link in the second paragraph to "Alerting and Actions". Should that be changed to "Alerting"?

@gchaps Updated!

gchaps
gchaps approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lcawl
lcawl approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, thanks!

@ymao1 ymao1 merged commit c727b40 into elastic:master Jun 14, 2021
ymao1 added a commit to ymao1/elasticsearch that referenced this pull request Jun 14, 2021
@ymao1
[Docs] Update cross-document links to Kibana Alerting docs (elastic#7…
d3aebda 
…4034)

* Updating cross-document links

* PR fixes
@ymao1 ymao1 mentioned this pull request Jun 14, 2021
Merged
ymao1 added a commit that referenced this pull request Jun 14, 2021
@ymao1
[Docs] Update cross-document links to Kibana Alerting docs (#74034) (#…
b2feedf 
…74091)

* Updating cross-document links

* PR fixes
@ymao1 ymao1 mentioned this pull request Jun 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcawl lcawl lcawl approved these changes

@gchaps gchaps gchaps approved these changes

Assignees

@ymao1 ymao1

Labels
external-contributor Pull request authored by a developer outside the Elasticsearch team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ymao1 @lcawl @gchaps @elasticsearchmachine