Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO][Inventory V2] Remove tour experience #204263

Closed
roshan-elastic opened this issue Dec 13, 2024 · 3 comments · Fixed by #205534
Closed

[ECO][Inventory V2] Remove tour experience #204263

roshan-elastic opened this issue Dec 13, 2024 · 3 comments · Fixed by #205534
Assignees
@jennypavlova
Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@roshan-elastic
Copy link

Can we comment out the tour experience (i.e. modal that shows upon first enabling inventory)?

Context : We are going to remove documentation and this will point towards this removed documentation
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 13, 2024
@roshan-elastic
Copy link
Author

@jennypavlova @rmyz @iblancof - Is this easy enough to comment out? Maybe the work is already done in #203095?

Image

@iblancof
Copy link
Contributor

Hi @roshan-elastic,

If this appears right after enabling the Inventory, from my POV it makes sense to handle it as part of #203095.
I'll link this issue as a sub-issue and update the acceptance criteria to include it.

cc @jennypavlova @rmyz

@iblancof iblancof mentioned this issue Dec 16, 2024
Closed
@dmlemeshko dmlemeshko added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Dec 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 23, 2024
@jennypavlova jennypavlova self-assigned this Jan 3, 2025
@jennypavlova jennypavlova mentioned this issue Jan 3, 2025
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jan 8, 2025
@jennypavlova
[ECO][Inventory v2] Remove the landing page to enable the entity model (
ab9cf56 
elastic#205534)

Closes elastic#203095
Closes elastic#204263

## Summary

This PR removes the page for the enabling functionality and welcome
screen. After the migration to v2 API we don't need to enable it anymore
as we are not using transforms

### Before:

![image](https://github.com/user-attachments/assets/0c8d5841-9189-4551-a1be-87801cfcf57d)

![image](https://github.com/user-attachments/assets/75a73dd8-6b16-452b-abcf-41e1fcca6645)

### After:
The same without the extra step to enable the entities and the welcome
screen:
- No data:

![image](https://github.com/user-attachments/assets/dbfdf501-36e7-4b6f-a8b6-ed0a6748ab62)

- With data:

![image](https://github.com/user-attachments/assets/0bbb2983-4e0a-477c-ac11-d2256b5ff854)

## Testing

- In a local environment enable the entities feature flag ( it should be
a clean env as the entities should not be enabled before ):
<img width="1911" alt="image"
src="https://github.com/user-attachments/assets/75d6f77d-5039-41ca-80ca-34c3bf99844e"
/>

- Go to Inventory
- Check before and after ingesting data
- Synthtrace: `node scripts/synthtrace logs_traces_hosts.ts` - ~⚠️ this
case can't be checked before
elastic#203452 is merged~ -
elastic#203452 is merged 🎉

(cherry picked from commit d6e28f7)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Jan 13, 2025
@jennypavlova @CAWilson94
[ECO][Inventory v2] Remove the landing page to enable the entity model (
6c954a6 
elastic#205534)

Closes elastic#203095
Closes elastic#204263


## Summary

This PR removes the page for the enabling functionality and welcome
screen. After the migration to v2 API we don't need to enable it anymore
as we are not using transforms

### Before: 


![image](https://github.com/user-attachments/assets/0c8d5841-9189-4551-a1be-87801cfcf57d)


![image](https://github.com/user-attachments/assets/75a73dd8-6b16-452b-abcf-41e1fcca6645)

### After: 
The same without the extra step to enable the entities and the welcome
screen:
- No data: 

![image](https://github.com/user-attachments/assets/dbfdf501-36e7-4b6f-a8b6-ed0a6748ab62)

- With data:

![image](https://github.com/user-attachments/assets/0bbb2983-4e0a-477c-ac11-d2256b5ff854)

## Testing

- In a local environment enable the entities feature flag ( it should be
a clean env as the entities should not be enabled before ):
<img width="1911" alt="image"
src="https://github.com/user-attachments/assets/75d6f77d-5039-41ca-80ca-34c3bf99844e"
/>

- Go to Inventory 
- Check before and after ingesting data
- Synthtrace: `node scripts/synthtrace logs_traces_hosts.ts` - ~⚠️ this
case can't be checked before
elastic#203452 is merged~ -
elastic#203452 is merged 🎉
viduni94 pushed a commit to viduni94/kibana that referenced this issue Jan 23, 2025
@jennypavlova @viduni94
[ECO][Inventory v2] Remove the landing page to enable the entity model (
bfc5bb2 
elastic#205534)

Closes elastic#203095
Closes elastic#204263


## Summary

This PR removes the page for the enabling functionality and welcome
screen. After the migration to v2 API we don't need to enable it anymore
as we are not using transforms

### Before: 


![image](https://github.com/user-attachments/assets/0c8d5841-9189-4551-a1be-87801cfcf57d)


![image](https://github.com/user-attachments/assets/75a73dd8-6b16-452b-abcf-41e1fcca6645)

### After: 
The same without the extra step to enable the entities and the welcome
screen:
- No data: 

![image](https://github.com/user-attachments/assets/dbfdf501-36e7-4b6f-a8b6-ed0a6748ab62)

- With data:

![image](https://github.com/user-attachments/assets/0bbb2983-4e0a-477c-ac11-d2256b5ff854)

## Testing

- In a local environment enable the entities feature flag ( it should be
a clean env as the entities should not be enabled before ):
<img width="1911" alt="image"
src="https://github.com/user-attachments/assets/75d6f77d-5039-41ca-80ca-34c3bf99844e"
/>

- Go to Inventory 
- Check before and after ingesting data
- Synthtrace: `node scripts/synthtrace logs_traces_hosts.ts` - ~⚠️ this
case can't be checked before
elastic#203452 is merged~ -
elastic#203452 is merged 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennypavlova jennypavlova

Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ECO][Inventory v2] Remove the landing page to enable the entity model jennypavlova/kibana
5 participants
@dmlemeshko @jennypavlova @elasticmachine @roshan-elastic @iblancof