[ECO][Inventory v2] Remove the landing page to enable the entity model #203095
Assignees
Labels
Comments
jennypavlova
added
the
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
|
@elastic/obs-entities After we remove the UI option to enable the entities and fully migrate to V2 we will be save to remove the EEM part of the entity manager responsible for that, right? Or do we still need to keep the transforms and the enabling logic? Should I add an issue for that ot you already have that in mind? |
|
Already removed in #204536 |
|
@miltonhultgren Nice, thanks for linking that! I was thinking also about those EntityClient endpoints when we remove the usage here - or are they still needed? |
|
If I understood @klacabane, we will remove those in a follow up, I suppose once you remove your usage of them! |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Jan 8, 2025
elastic#205534) Closes elastic#203095 Closes elastic#204263 ## Summary This PR removes the page for the enabling functionality and welcome screen. After the migration to v2 API we don't need to enable it anymore as we are not using transforms ### Before:   ### After: The same without the extra step to enable the entities and the welcome screen: - No data:  - With data:  ## Testing - In a local environment enable the entities feature flag ( it should be a clean env as the entities should not be enabled before ): <img width="1911" alt="image" src="https://github.com/user-attachments/assets/75d6f77d-5039-41ca-80ca-34c3bf99844e" /> - Go to Inventory - Check before and after ingesting data - Synthtrace: `node scripts/synthtrace logs_traces_hosts.ts` - ~⚠️ this case can't be checked before elastic#203452 is merged~ - elastic#203452 is merged 🎉 (cherry picked from commit d6e28f7)
kibanamachine
added a commit
that referenced
this issue
Jan 8, 2025
…y model (#205534) (#205958) # Backport This will backport the following commits from `main` to `8.x`: - [[ECO][Inventory v2] Remove the landing page to enable the entity model (#205534)](#205534) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T19:30:17Z","message":"[ECO][Inventory v2] Remove the landing page to enable the entity model (#205534)\n\nCloses #203095\r\nCloses https://github.com/elastic/kibana/issues/204263\r\n\r\n\r\n## Summary\r\n\r\nThis PR removes the page for the enabling functionality and welcome\r\nscreen. After the migration to v2 API we don't need to enable it anymore\r\nas we are not using transforms\r\n\r\n### Before: \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### After: \r\nThe same without the extra step to enable the entities and the welcome\r\nscreen:\r\n- No data: \r\n\r\n\r\n\r\n- With data:\r\n\r\n\r\n\r\n## Testing\r\n\r\n- In a local environment enable the entities feature flag ( it should be\r\na clean env as the entities should not be enabled before ):\r\n<img width=\"1911\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/75d6f77d-5039-41ca-80ca-34c3bf99844e\"\r\n/>\r\n\r\n- Go to Inventory \r\n- Check before and after ingesting data\r\n- Synthtrace: `node scripts/synthtrace logs_traces_hosts.ts` - ~⚠️ this\r\ncase can't be checked before\r\nhttps://github.com//pull/203452 is merged~ -\r\nhttps://github.com//pull/203452 is merged 🎉","sha":"d6e28f766ac5363b4a6888871a2813538a4ee367","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-infra_services"],"title":"[ECO][Inventory v2] Remove the landing page to enable the entity model","number":205534,"url":"https://github.com/elastic/kibana/pull/205534","mergeCommit":{"message":"[ECO][Inventory v2] Remove the landing page to enable the entity model (#205534)\n\nCloses #203095\r\nCloses https://github.com/elastic/kibana/issues/204263\r\n\r\n\r\n## Summary\r\n\r\nThis PR removes the page for the enabling functionality and welcome\r\nscreen. After the migration to v2 API we don't need to enable it anymore\r\nas we are not using transforms\r\n\r\n### Before: \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### After: \r\nThe same without the extra step to enable the entities and the welcome\r\nscreen:\r\n- No data: \r\n\r\n\r\n\r\n- With data:\r\n\r\n\r\n\r\n## Testing\r\n\r\n- In a local environment enable the entities feature flag ( it should be\r\na clean env as the entities should not be enabled before ):\r\n<img width=\"1911\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/75d6f77d-5039-41ca-80ca-34c3bf99844e\"\r\n/>\r\n\r\n- Go to Inventory \r\n- Check before and after ingesting data\r\n- Synthtrace: `node scripts/synthtrace logs_traces_hosts.ts` - ~⚠️ this\r\ncase can't be checked before\r\nhttps://github.com//pull/203452 is merged~ -\r\nhttps://github.com//pull/203452 is merged 🎉","sha":"d6e28f766ac5363b4a6888871a2813538a4ee367"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205534","number":205534,"mergeCommit":{"message":"[ECO][Inventory v2] Remove the landing page to enable the entity model (#205534)\n\nCloses #203095\r\nCloses https://github.com/elastic/kibana/issues/204263\r\n\r\n\r\n## Summary\r\n\r\nThis PR removes the page for the enabling functionality and welcome\r\nscreen. After the migration to v2 API we don't need to enable it anymore\r\nas we are not using transforms\r\n\r\n### Before: \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### After: \r\nThe same without the extra step to enable the entities and the welcome\r\nscreen:\r\n- No data: \r\n\r\n\r\n\r\n- With data:\r\n\r\n\r\n\r\n## Testing\r\n\r\n- In a local environment enable the entities feature flag ( it should be\r\na clean env as the entities should not be enabled before ):\r\n<img width=\"1911\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/75d6f77d-5039-41ca-80ca-34c3bf99844e\"\r\n/>\r\n\r\n- Go to Inventory \r\n- Check before and after ingesting data\r\n- Synthtrace: `node scripts/synthtrace logs_traces_hosts.ts` - ~⚠️ this\r\ncase can't be checked before\r\nhttps://github.com//pull/203452 is merged~ -\r\nhttps://github.com//pull/203452 is merged 🎉","sha":"d6e28f766ac5363b4a6888871a2813538a4ee367"}}]}] BACKPORT--> Co-authored-by: jennypavlova <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this issue
Jan 13, 2025
elastic#205534) Closes elastic#203095 Closes elastic#204263 ## Summary This PR removes the page for the enabling functionality and welcome screen. After the migration to v2 API we don't need to enable it anymore as we are not using transforms ### Before:   ### After: The same without the extra step to enable the entities and the welcome screen: - No data:  - With data:  ## Testing - In a local environment enable the entities feature flag ( it should be a clean env as the entities should not be enabled before ): <img width="1911" alt="image" src="https://github.com/user-attachments/assets/75d6f77d-5039-41ca-80ca-34c3bf99844e" /> - Go to Inventory - Check before and after ingesting data - Synthtrace: `node scripts/synthtrace logs_traces_hosts.ts` - ~⚠️ this case can't be checked before elastic#203452 is merged~ - elastic#203452 is merged 🎉
viduni94
pushed a commit
to viduni94/kibana
that referenced
this issue
Jan 23, 2025
elastic#205534) Closes elastic#203095 Closes elastic#204263 ## Summary This PR removes the page for the enabling functionality and welcome screen. After the migration to v2 API we don't need to enable it anymore as we are not using transforms ### Before:   ### After: The same without the extra step to enable the entities and the welcome screen: - No data:  - With data:  ## Testing - In a local environment enable the entities feature flag ( it should be a clean env as the entities should not be enabled before ): <img width="1911" alt="image" src="https://github.com/user-attachments/assets/75d6f77d-5039-41ca-80ca-34c3bf99844e" /> - Go to Inventory - Check before and after ingesting data - Synthtrace: `node scripts/synthtrace logs_traces_hosts.ts` - ~⚠️ this case can't be checked before elastic#203452 is merged~ - elastic#203452 is merged 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After the work in this Epic is done as a last step we want to remove the landing page with the enable action. Now that we won't be using transforms anymore we don't need the enable functionality.
This Page should be removed and instead, we should show the inventory view:
AC:
The text was updated successfully, but these errors were encountered: