[Security Solution]Missing Inspect modal Title for all 3 view of Alerts charts #136372
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
fixed
impact:low
Addressing this issue will have a low level of impact on the quality/strength of our product.
QA:Validated
Issue has been validated by QA
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:Threat Hunting:Investigations
Security Solution Investigations Team
Team:Threat Hunting
Security Solution Threat Hunting Team
v8.4.0
Comments
ghost
added
bug
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
ghost
added
the
impact:low
MadameSheema
added
Team:Threat Hunting
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
andrew-goldstein
added a commit
to andrew-goldstein/kibana
that referenced
this issue
Aug 1, 2022
This PR contains fixes for the following issues: - elastic#136377 was fixed by using the `key_as_string` value in the search strategy response to format timestamps for the Treemap and Table views, per the screenshots below: **Treemap with timestamp formatting:**  **Table with timestamp formatting:**  - elastic#136387 was fixed by reducing the mininum font size to `4px` for group names, per [this example](https://elastic.github.io/elastic-charts/?path=/story/treemap--two-layers-stress-test&globals=theme:light;background:white) from Elastic charts. This change: - Reduces the chances of a label getting hidden when the browser is resized, but cannot eliminate it, because at a certain point, Elastic Charts must hide the label in order to (still) render the group - Will result in some groups having very small labels where the group previously would not have them, per the screenshot below:  - elastic#136372 was fixed by adding the word `Trend`, `Table`, and `Treemap` to the inspect modal for each of the respective chart types, per the screenshots below: **Inspect Trend:**  **Inspect Table:**  **Inspect Treemap:**  - [review feedback](elastic#126896 (review)) where the `Tree map isn't displayed for certain group by top fields, like Ransomeware.version`, was fixed as suggested by displaying an empty state message with a reason why the treemap cannot be displayed: **Before:**  **After:**  - [review feedback](elastic#126896 (review)) where there were `Extra left margins when the Table view is selected` was fixed by removing the extra margin: **Before:**  **After:** 
andrew-goldstein
added a commit
that referenced
this issue
Aug 2, 2022
## [Security Solution] Alerts Treemap fixes This PR contains fixes for the following issues: - #136377 was fixed by using the `key_as_string` value in the search strategy response to format timestamps for the Treemap and Table views, per the screenshots below: **Treemap with timestamp formatting:**  **Table with timestamp formatting:**  - #136387 was fixed by reducing the mininum font size to `4px` for group names, per [this example](https://elastic.github.io/elastic-charts/?path=/story/treemap--two-layers-stress-test&globals=theme:light;background:white) from Elastic charts. This change: - Reduces the chances of a label getting hidden when the browser is resized, but cannot eliminate it, because at a certain point, Elastic Charts must hide the label in order to (still) render the group - Will result in some groups having very small labels where the group previously would not have them, per the screenshot below:  - #136372 was fixed by adding the word `Trend`, `Table`, and `Treemap` to the inspect modal for each of the respective chart types, per the screenshots below: **Inspect Trend:**  **Inspect Table:**  **Inspect Treemap:**  - [review feedback](#126896 (review)) where the `Tree map isn't displayed for certain group by top fields, like Ransomeware.version`, was fixed as suggested by displaying an empty state message with a reason why the treemap cannot be displayed: **Before:**  **After:**  - [review feedback](#126896 (review)) where there were `Extra left margins when the Table view is selected` was fixed by removing the extra margin: **Before:**  **After:** 
kibanamachine
pushed a commit
that referenced
this issue
Aug 2, 2022
## [Security Solution] Alerts Treemap fixes This PR contains fixes for the following issues: - #136377 was fixed by using the `key_as_string` value in the search strategy response to format timestamps for the Treemap and Table views, per the screenshots below: **Treemap with timestamp formatting:**  **Table with timestamp formatting:**  - #136387 was fixed by reducing the mininum font size to `4px` for group names, per [this example](https://elastic.github.io/elastic-charts/?path=/story/treemap--two-layers-stress-test&globals=theme:light;background:white) from Elastic charts. This change: - Reduces the chances of a label getting hidden when the browser is resized, but cannot eliminate it, because at a certain point, Elastic Charts must hide the label in order to (still) render the group - Will result in some groups having very small labels where the group previously would not have them, per the screenshot below:  - #136372 was fixed by adding the word `Trend`, `Table`, and `Treemap` to the inspect modal for each of the respective chart types, per the screenshots below: **Inspect Trend:**  **Inspect Table:**  **Inspect Treemap:**  - [review feedback](#126896 (review)) where the `Tree map isn't displayed for certain group by top fields, like Ransomeware.version`, was fixed as suggested by displaying an empty state message with a reason why the treemap cannot be displayed: **Before:**  **After:**  - [review feedback](#126896 (review)) where there were `Extra left margins when the Table view is selected` was fixed by removing the extra margin: **Before:**  **After:**  (cherry picked from commit a5a7d74)
kibanamachine
added a commit
that referenced
this issue
Aug 2, 2022
## [Security Solution] Alerts Treemap fixes This PR contains fixes for the following issues: - #136377 was fixed by using the `key_as_string` value in the search strategy response to format timestamps for the Treemap and Table views, per the screenshots below: **Treemap with timestamp formatting:**  **Table with timestamp formatting:**  - #136387 was fixed by reducing the mininum font size to `4px` for group names, per [this example](https://elastic.github.io/elastic-charts/?path=/story/treemap--two-layers-stress-test&globals=theme:light;background:white) from Elastic charts. This change: - Reduces the chances of a label getting hidden when the browser is resized, but cannot eliminate it, because at a certain point, Elastic Charts must hide the label in order to (still) render the group - Will result in some groups having very small labels where the group previously would not have them, per the screenshot below:  - #136372 was fixed by adding the word `Trend`, `Table`, and `Treemap` to the inspect modal for each of the respective chart types, per the screenshots below: **Inspect Trend:**  **Inspect Table:**  **Inspect Treemap:**  - [review feedback](#126896 (review)) where the `Tree map isn't displayed for certain group by top fields, like Ransomeware.version`, was fixed as suggested by displaying an empty state message with a reason why the treemap cannot be displayed: **Before:**  **After:**  - [review feedback](#126896 (review)) where there were `Extra left margins when the Table view is selected` was fixed by removing the extra margin: **Before:**  **After:**  (cherry picked from commit a5a7d74) Co-authored-by: Andrew Goldstein <[email protected]>
|
Fixed in:
|
|
@karanbirsingh-qasource would you be willing to test the fix for this issue? |
|
sure @andrew-goldstein |
|
we have validated this issue on 8.4.0 BC2 and found the issue to be fixed now ✔️ . Build Details: Screen-Shoot:
Hence we are closing this issue and adding "QA:Validated" thanks !! |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Missing Inspect modal Title for all 3 view of Alerts charts
Build Details:
Steps
Expected Result
In 8.3.0 we used to show Trend in title of inspect modal
Screen-Shoot
The text was updated successfully, but these errors were encountered: