Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections] Signals migration status endpoint contains unrelated system indices #100305

Closed
rylnd opened this issue May 18, 2021 · 2 comments · Fixed by #101682
Closed

[Security Solution][Detections] Signals migration status endpoint contains unrelated system indices #100305

rylnd opened this issue May 18, 2021 · 2 comments · Fixed by #101682
Assignees
@rylnd @FrankHassanabad
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.14.0

Comments

@rylnd
Copy link
Contributor

rylnd commented May 18, 2021 •
edited
Loading

Due to the addition of kibana system datastreams and the behavior addressed in elastic/elasticsearch#72953, the current behavior on master is that the migration status endpoint contains unrelated indices:

Example response ```json { "indices": [ { "index": ".siem-signals-default-000001", "version": 35, "signal_versions": [ { "version": 35, "count": 60 } ], "migrations": [], "is_outdated": false }, { "index": ".ds-ilm-history-5-2021.05.06-000001", "version": 0, "signal_versions": [ { "version": "0", "count": 12 } ], "migrations": [], "is_outdated": true } ] } ```

While those indices are unable to be migrated via the API and thus do not pose any data integrity issue, their appearance in the status API is bad UX. Luckily, the above PR should address this behavior.

This issue, then, is meant to note the current behavior and serve as a reminder to verify the above fix and unskip the corresponding integration test from #99915.
@rylnd rylnd added bug Fixes for quality problems that affect the customer experience Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.14.0 labels May 18, 2021
@rylnd rylnd self-assigned this May 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label May 26, 2021
@FrankHassanabad FrankHassanabad mentioned this issue Jun 8, 2021
Merged
1 task
@FrankHassanabad FrankHassanabad linked a pull request Jun 8, 2021 that will close this issue
[Security Solutions][Detection Engine] Unskips signal migration tests now that elastic search is fixed #101682
Merged
1 task
FrankHassanabad added a commit that referenced this issue Jun 9, 2021
@FrankHassanabad
Unskips migration tests now that elastic search is fixed (#101682)
8c03ccf 
## Summary

Unskips signal migration tests now that elastic search is fixed get alias bug

ES ticket about get alias bug:
elastic/elasticsearch#72953

Tickets related that should be fixed now:
#99915
#100305

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@FrankHassanabad FrankHassanabad self-assigned this Jun 9, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jun 9, 2021
@FrankHassanabad @kibanamachine
Unskips migration tests now that elastic search is fixed (elastic#101682
bdfd91e 
)

## Summary

Unskips signal migration tests now that elastic search is fixed get alias bug

ES ticket about get alias bug:
elastic/elasticsearch#72953

Tickets related that should be fixed now:
elastic#99915
elastic#100305

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine added a commit that referenced this issue Jun 9, 2021
@kibanamachine @FrankHassanabad
Unskips migration tests now that elastic search is fixed (#101682) (#…
253da63 
…101831)

## Summary

Unskips signal migration tests now that elastic search is fixed get alias bug

ES ticket about get alias bug:
elastic/elasticsearch#72953

Tickets related that should be fixed now:
#99915
#100305

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

Co-authored-by: Frank Hassanabad <[email protected]>
semd pushed a commit that referenced this issue Jun 10, 2021
@FrankHassanabad @semd
Unskips migration tests now that elastic search is fixed (#101682)
c7eb4ce 
## Summary

Unskips signal migration tests now that elastic search is fixed get alias bug

ES ticket about get alias bug:
elastic/elasticsearch#72953

Tickets related that should be fixed now:
#99915
#100305

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rylnd rylnd

@FrankHassanabad FrankHassanabad

Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.14.0
Projects
None yet
Milestone
No milestone
4 participants
@rylnd @FrankHassanabad @elasticmachine @MadameSheema