-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The get aliases api should not return entries for data streams with no aliases #72953
The get aliases api should not return entries for data streams with no aliases #72953
Conversation
The get alias api should take into account the aliases parameter when returning aliases that refer to data streams. Relates to elastic#66163
Pinging @elastic/es-core-features (Team:Core/Features) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this PR is intended to address this, but when testing this API, GET _alias
returns data stream aliases but if GET _alias/dataStreamAlias
is attempted, a 404 is returned.
I completely missed that. This is a different bug in This PR avoids returning entries for data streams that don't match with the provided alias name.
While the following is expected:
(at least this matches the behaviour with aliases pointing to indices) |
Another PR is fine. I was just testing it in an attempt to understand what this PR did. Thanks for the explanation. |
Change the get alias api to not return a 404 when filtering by alias name that refers to data streams. Originated from elastic#72953 Relates to elastic#66163
Backport elastic#73140 to 7.x branch. Change the get alias api to not return a 404 when filtering by alias name that refers to data streams. Originated from elastic#72953 Relates to elastic#66163
…o aliases Backport elastic#72953 to 7.x branch. The get alias api should take into account the aliases parameter when returning aliases that refer to data streams and don't return entries for data streams that don't have any aliases pointing to it. Relates to elastic#66163
## Summary Unskips signal migration tests now that elastic search is fixed get alias bug ES ticket about get alias bug: elastic/elasticsearch#72953 Tickets related that should be fixed now: #99915 #100305 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
) ## Summary Unskips signal migration tests now that elastic search is fixed get alias bug ES ticket about get alias bug: elastic/elasticsearch#72953 Tickets related that should be fixed now: elastic#99915 elastic#100305 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
…101831) ## Summary Unskips signal migration tests now that elastic search is fixed get alias bug ES ticket about get alias bug: elastic/elasticsearch#72953 Tickets related that should be fixed now: #99915 #100305 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Frank Hassanabad <[email protected]>
## Summary Unskips signal migration tests now that elastic search is fixed get alias bug ES ticket about get alias bug: elastic/elasticsearch#72953 Tickets related that should be fixed now: #99915 #100305 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
The get alias api should take into account the aliases parameter when
returning aliases that refer to data streams and don't return entries
for data streams that don't have any aliases pointing to it.
Relates to #66163