Skip to content

Commit

Permalink
[8.x] Make saved_objects_tagging plugin shared (#205695) (#205868)
Browse files Browse the repository at this point in the history
# Backport

This will backport the following commits from `main` to `8.x`:
- [Make `saved_objects_tagging` plugin shared
(#205695)](#205695)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T17:15:17Z","message":"Make
`saved_objects_tagging` plugin shared (#205695)\n\n## Summary\r\n\r\nSo
that it can be used from `streams_app` (o11y).\r\nSee
https://github.com/elastic/kibana/pull/204309\r\n\r\nSteps to
relocate:\r\n\r\n1. Fetch latest `main`\r\n2. Update the `group` and/or
`visibility` in the module's manifest.\r\n3. Run `node scripts/relocate
--moveOnly\r\n@kbn/saved-objects-tagging-plugin`","sha":"a8579bb41f08ead668f0882ce8605ab8e8c07d2b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:prev-minor"],"number":205695,"url":"https://github.com/elastic/kibana/pull/205695","mergeCommit":{"message":"Make
`saved_objects_tagging` plugin shared (#205695)\n\n## Summary\r\n\r\nSo
that it can be used from `streams_app` (o11y).\r\nSee
https://github.com/elastic/kibana/pull/204309\r\n\r\nSteps to
relocate:\r\n\r\n1. Fetch latest `main`\r\n2. Update the `group` and/or
`visibility` in the module's manifest.\r\n3. Run `node scripts/relocate
--moveOnly\r\n@kbn/saved-objects-tagging-plugin`","sha":"a8579bb41f08ead668f0882ce8605ab8e8c07d2b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205695","number":205695,"mergeCommit":{"message":"Make
`saved_objects_tagging` plugin shared (#205695)\n\n## Summary\r\n\r\nSo
that it can be used from `streams_app` (o11y).\r\nSee
https://github.com/elastic/kibana/pull/204309\r\n\r\nSteps to
relocate:\r\n\r\n1. Fetch latest `main`\r\n2. Update the `group` and/or
`visibility` in the module's manifest.\r\n3. Run `node scripts/relocate
--moveOnly\r\n@kbn/saved-objects-tagging-plugin`","sha":"a8579bb41f08ead668f0882ce8605ab8e8c07d2b"}}]}]
BACKPORT-->

Co-authored-by: Elastic Machine <[email protected]>
  • Loading branch information
gsoldevila and elasticmachine authored Jan 9, 2025
1 parent e48679a commit da866fc
Show file tree
Hide file tree
Showing 170 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -774,7 +774,7 @@ src/platform/plugins/shared/saved_objects_management @elastic/kibana-core
src/platform/plugins/shared/saved_objects @elastic/kibana-core
packages/kbn-saved-objects-settings @elastic/appex-sharedux
src/platform/plugins/shared/saved_objects_tagging_oss @elastic/appex-sharedux
x-pack/platform/plugins/private/saved_objects_tagging @elastic/appex-sharedux
x-pack/platform/plugins/shared/saved_objects_tagging @elastic/appex-sharedux
packages/kbn-saved-search-component @elastic/obs-ux-logs-team
src/platform/plugins/shared/saved_search @elastic/kibana-data-discovery
packages/kbn-scout @elastic/appex-qa
Expand Down
2 changes: 1 addition & 1 deletion docs/developer/plugin-list.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@ Elastic.
|Welcome to the home of the runtime field editor and everything related to runtime fields!
|{kib-repo}blob/{branch}/x-pack/platform/plugins/private/saved_objects_tagging/README.md[savedObjectsTagging]
|{kib-repo}blob/{branch}/x-pack/platform/plugins/shared/saved_objects_tagging/README.md[savedObjectsTagging]
|Add tagging capability to saved objects
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,7 @@
"@kbn/saved-objects-plugin": "link:src/platform/plugins/shared/saved_objects",
"@kbn/saved-objects-settings": "link:packages/kbn-saved-objects-settings",
"@kbn/saved-objects-tagging-oss-plugin": "link:src/platform/plugins/shared/saved_objects_tagging_oss",
"@kbn/saved-objects-tagging-plugin": "link:x-pack/platform/plugins/private/saved_objects_tagging",
"@kbn/saved-objects-tagging-plugin": "link:x-pack/platform/plugins/shared/saved_objects_tagging",
"@kbn/saved-search-component": "link:packages/kbn-saved-search-component",
"@kbn/saved-search-plugin": "link:src/platform/plugins/shared/saved_search",
"@kbn/screenshot-mode-example-plugin": "link:examples/screenshot_mode_example",
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -1542,8 +1542,8 @@
"@kbn/saved-objects-settings/*": ["packages/kbn-saved-objects-settings/*"],
"@kbn/saved-objects-tagging-oss-plugin": ["src/platform/plugins/shared/saved_objects_tagging_oss"],
"@kbn/saved-objects-tagging-oss-plugin/*": ["src/platform/plugins/shared/saved_objects_tagging_oss/*"],
"@kbn/saved-objects-tagging-plugin": ["x-pack/platform/plugins/private/saved_objects_tagging"],
"@kbn/saved-objects-tagging-plugin/*": ["x-pack/platform/plugins/private/saved_objects_tagging/*"],
"@kbn/saved-objects-tagging-plugin": ["x-pack/platform/plugins/shared/saved_objects_tagging"],
"@kbn/saved-objects-tagging-plugin/*": ["x-pack/platform/plugins/shared/saved_objects_tagging/*"],
"@kbn/saved-search-component": ["packages/kbn-saved-search-component"],
"@kbn/saved-search-component/*": ["packages/kbn-saved-search-component/*"],
"@kbn/saved-search-plugin": ["src/platform/plugins/shared/saved_search"],
Expand Down
2 changes: 1 addition & 1 deletion x-pack/.i18nrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@
"xpack.snapshotRestore": "platform/plugins/private/snapshot_restore",
"xpack.spaces": "platform/plugins/shared/spaces",
"xpack.savedObjectsTagging": [
"platform/plugins/private/saved_objects_tagging"
"platform/plugins/shared/saved_objects_tagging"
],
"xpack.taskManager": "legacy/platform/plugins/shared/task_manager",
"xpack.threatIntelligence": "solutions/security/plugins/threat_intelligence",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ features.registerKibanaFeature({

### Update the SOT telemetry collector schema to add the new type

The schema is located here: `x-pack/platform/plugins/private/saved_objects_tagging/server/usage/schema.ts`. You
The schema is located here: `x-pack/platform/plugins/shared/saved_objects_tagging/server/usage/schema.ts`. You
just need to add the name of the SO type you are adding.

```ts
Expand All @@ -54,5 +54,5 @@ export const tagUsageCollectorSchema: MakeSchemaFrom<TaggingUsageData> = {

### Update the `taggableTypes` constant to add your type

Edit the `taggableTypes` list in `x-pack/platform/plugins/private/saved_objects_tagging/common/constants.ts` to add
Edit the `taggableTypes` list in `x-pack/platform/plugins/shared/saved_objects_tagging/common/constants.ts` to add
the name of the type you are adding.
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
module.exports = {
preset: '@kbn/test',
rootDir: '../../../../..',
roots: ['<rootDir>/x-pack/platform/plugins/private/saved_objects_tagging'],
roots: ['<rootDir>/x-pack/platform/plugins/shared/saved_objects_tagging'],
coverageDirectory:
'<rootDir>/target/kibana-coverage/jest/x-pack/platform/plugins/private/saved_objects_tagging',
'<rootDir>/target/kibana-coverage/jest/x-pack/platform/plugins/shared/saved_objects_tagging',
coverageReporters: ['text', 'html'],
collectCoverageFrom: [
'<rootDir>/x-pack/platform/plugins/private/saved_objects_tagging/{common,public,server}/**/*.{ts,tsx}',
'<rootDir>/x-pack/platform/plugins/shared/saved_objects_tagging/{common,public,server}/**/*.{ts,tsx}',
],
};
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"@elastic/appex-sharedux"
],
"group": "platform",
"visibility": "private",
"visibility": "shared",
"plugin": {
"id": "savedObjectsTagging",
"browser": true,
Expand All @@ -25,4 +25,4 @@
],
"requiredBundles": []
}
}
}
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6936,7 +6936,7 @@
version "0.0.0"
uid ""

"@kbn/saved-objects-tagging-plugin@link:x-pack/platform/plugins/private/saved_objects_tagging":
"@kbn/saved-objects-tagging-plugin@link:x-pack/platform/plugins/shared/saved_objects_tagging":
version "0.0.0"
uid ""

Expand Down

0 comments on commit da866fc

Please sign in to comment.