Skip to content

Commit

Permalink
[8.x] Add waitUntilLoadingHasFinished in failing tests (#205485) (#20…
Browse files Browse the repository at this point in the history 
…5862)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Add waitUntilLoadingHasFinished in failing tests
(#205485)](#205485)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sonia Sanz
Vivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T10:51:34Z","message":"Add
waitUntilLoadingHasFinished in failing tests (#205485)\n\nFixes:
https://github.com/elastic/kibana/issues/205535\nFixes:
https://github.com/elastic/kibana/issues/205514\nFixes:
https://github.com/elastic/kibana/issues/205498\nFixes:
https://github.com/elastic/kibana/issues/205464\nFixes:
https://github.com/elastic/kibana/issues/205456\nFixes:
https://github.com/elastic/kibana/issues/205453\nFixes:
https://github.com/elastic/kibana/issues/205450\nFixes:
https://github.com/elastic/kibana/issues/205412\nFixes:
https://github.com/elastic/kibana/issues/205410\nFixes:
https://github.com/elastic/kibana/issues/205401\nFixes:
https://github.com/elastic/kibana/issues/205400\nFixes:
https://github.com/elastic/kibana/issues/205399\nFixes:
https://github.com/elastic/kibana/issues/205350\nFixes:
https://github.com/elastic/kibana/issues/205349\nFixes:
https://github.com/elastic/kibana/issues/205316\nFixes:
https://github.com/elastic/kibana/issues/205288\nFixes:
https://github.com/elastic/kibana/issues/205287\n\n## Summary\nIt seems
that the step tabs are not loading fast enough for the tests to\nfind
the expected element in a [bunch
of\ntest](https://github.com/elastic/kibana/issues?q=is%3Aopen%20label%3A%22Team%3AKibana%20Management%22%20label%3A%22failed-test%22%20created%3A%3E%40today-1w%20).\nThis
PR attempt to fix it. It also adds
the\n`data-test-subj=\"indexModeValue\"` tag in `TabSummary` that was
missing.","sha":"bcdf942b94f5f11d9b2854afd0153e6b579461ac","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index
Management","Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"Add
waitUntilLoadingHasFinished in failing
tests","number":205485,"url":"https://github.com/elastic/kibana/pull/205485","mergeCommit":{"message":"Add
waitUntilLoadingHasFinished in failing tests (#205485)\n\nFixes:
https://github.com/elastic/kibana/issues/205535\nFixes:
https://github.com/elastic/kibana/issues/205514\nFixes:
https://github.com/elastic/kibana/issues/205498\nFixes:
https://github.com/elastic/kibana/issues/205464\nFixes:
https://github.com/elastic/kibana/issues/205456\nFixes:
https://github.com/elastic/kibana/issues/205453\nFixes:
https://github.com/elastic/kibana/issues/205450\nFixes:
https://github.com/elastic/kibana/issues/205412\nFixes:
https://github.com/elastic/kibana/issues/205410\nFixes:
https://github.com/elastic/kibana/issues/205401\nFixes:
https://github.com/elastic/kibana/issues/205400\nFixes:
https://github.com/elastic/kibana/issues/205399\nFixes:
https://github.com/elastic/kibana/issues/205350\nFixes:
https://github.com/elastic/kibana/issues/205349\nFixes:
https://github.com/elastic/kibana/issues/205316\nFixes:
https://github.com/elastic/kibana/issues/205288\nFixes:
https://github.com/elastic/kibana/issues/205287\n\n## Summary\nIt seems
that the step tabs are not loading fast enough for the tests to\nfind
the expected element in a [bunch
of\ntest](https://github.com/elastic/kibana/issues?q=is%3Aopen%20label%3A%22Team%3AKibana%20Management%22%20label%3A%22failed-test%22%20created%3A%3E%40today-1w%20).\nThis
PR attempt to fix it. It also adds
the\n`data-test-subj=\"indexModeValue\"` tag in `TabSummary` that was
missing.","sha":"bcdf942b94f5f11d9b2854afd0153e6b579461ac"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205485","number":205485,"mergeCommit":{"message":"Add
waitUntilLoadingHasFinished in failing tests (#205485)\n\nFixes:
https://github.com/elastic/kibana/issues/205535\nFixes:
https://github.com/elastic/kibana/issues/205514\nFixes:
https://github.com/elastic/kibana/issues/205498\nFixes:
https://github.com/elastic/kibana/issues/205464\nFixes:
https://github.com/elastic/kibana/issues/205456\nFixes:
https://github.com/elastic/kibana/issues/205453\nFixes:
https://github.com/elastic/kibana/issues/205450\nFixes:
https://github.com/elastic/kibana/issues/205412\nFixes:
https://github.com/elastic/kibana/issues/205410\nFixes:
https://github.com/elastic/kibana/issues/205401\nFixes:
https://github.com/elastic/kibana/issues/205400\nFixes:
https://github.com/elastic/kibana/issues/205399\nFixes:
https://github.com/elastic/kibana/issues/205350\nFixes:
https://github.com/elastic/kibana/issues/205349\nFixes:
https://github.com/elastic/kibana/issues/205316\nFixes:
https://github.com/elastic/kibana/issues/205288\nFixes:
https://github.com/elastic/kibana/issues/205287\n\n## Summary\nIt seems
that the step tabs are not loading fast enough for the tests to\nfind
the expected element in a [bunch
of\ntest](https://github.com/elastic/kibana/issues?q=is%3Aopen%20label%3A%22Team%3AKibana%20Management%22%20label%3A%22failed-test%22%20created%3A%3E%40today-1w%20).\nThis
PR attempt to fix it. It also adds
the\n`data-test-subj=\"indexModeValue\"` tag in `TabSummary` that was
missing.","sha":"bcdf942b94f5f11d9b2854afd0153e6b579461ac"}}]}]
BACKPORT-->

Co-authored-by: Sonia Sanz Vivas <[email protected]>
  • Loading branch information
@kibanamachine @SoniaSanzV
kibanamachine and SoniaSanzV authored Jan 9, 2025
1 parent 5cffe2e commit e48679a
Show file tree
Hide file tree
Showing 5 changed files with 31 additions and 51 deletions.
2 changes: 1 addition & 1 deletion ...ment/public/application/sections/home/template_list/template_details/tabs/tab_summary.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ export const TabSummary: React.FunctionComponent<Props> = ({ templateDetails })
defaultMessage="Index mode"
/>
</EuiDescriptionListTitle>
<EuiDescriptionListDescription>
<EuiDescriptionListDescription data-test-subj="indexModeValue">
{indexModeLabels[indexMode]}
</EuiDescriptionListDescription>
</>
Expand Down
33 changes: 13 additions & 20 deletions x-pack/test/functional/apps/index_management/data_streams_tab/data_streams_tab.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

// Click update template
await pageObjects.indexManagement.clickNextButton();
await pageObjects.header.waitUntilLoadingHasFinished();

// Verify index mode and close detail tab
expect(await testSubjects.getVisibleText('indexModeValue')).to.be(indexModeName);
Expand Down Expand Up @@ -322,11 +323,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

await changeIndexMode('index_mode_logsdb');
// Navigate to the last step of the wizard
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-5');
await pageObjects.header.waitUntilLoadingHasFinished();

await verifyModeHasBeenChanged(INDEX_MODE.LOGSDB);
});
Expand All @@ -339,11 +337,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

await changeIndexMode('index_mode_standard');
// Navigate to the last step of the wizard
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-5');
await pageObjects.header.waitUntilLoadingHasFinished();

await verifyModeHasBeenChanged(INDEX_MODE.STANDARD);
});
Expand All @@ -357,16 +352,15 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

await changeIndexMode('index_mode_logsdb');

await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-2');
await pageObjects.header.waitUntilLoadingHasFinished();
// Modify Index settings
await testSubjects.setValue('kibanaCodeEditor', '{}', {
clearWithKeyboard: true,
});
// Navigate to the last step of the wizard
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-5');
await pageObjects.header.waitUntilLoadingHasFinished();

await verifyModeHasBeenChanged(INDEX_MODE.LOGSDB);
});
Expand All @@ -379,8 +373,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

await changeIndexMode('index_mode_time_series');

await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-2');
await pageObjects.header.waitUntilLoadingHasFinished();
// Modify Index settings
await testSubjects.setValue(
'kibanaCodeEditor',
Expand All @@ -390,9 +384,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
}
);
// Navigate to the last step of the wizard
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-5');
await pageObjects.header.waitUntilLoadingHasFinished();

await verifyModeHasBeenChanged(INDEX_MODE.TIME_SERIES);
});
Expand Down
14 changes: 4 additions & 10 deletions x-pack/test/functional/apps/index_management/index_templates_tab/index_template_tab.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await testSubjects.click('show-filters-button');
await testSubjects.click('filter-option-h');
// Navigate to the last step of the wizard
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-5');
await pageObjects.header.waitUntilLoadingHasFinished();

expect(await testSubjects.getVisibleText('lifecycleValue')).to.be('7 hours');

Expand All @@ -71,11 +68,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await testSubjects.click('index_mode_logsdb');

// Navigate to the last step of the wizard
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-5');
await pageObjects.header.waitUntilLoadingHasFinished();

expect(await testSubjects.exists('indexModeTitle')).to.be(true);
expect(await testSubjects.getVisibleText('indexModeValue')).to.be('LogsDB');
Expand Down
31 changes: 11 additions & 20 deletions ...test_serverless/functional/test_suites/common/management/index_management/data_streams.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

// Click update template
await pageObjects.indexManagement.clickNextButton();
await pageObjects.header.waitUntilLoadingHasFinished();

// Verify index mode and close detail tab
expect(await testSubjects.getVisibleText('indexModeValue')).to.be(indexModeName);
Expand Down Expand Up @@ -245,11 +246,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

await changeIndexMode('index_mode_logsdb');
// Navigate to the last step of the wizard
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-5');
await pageObjects.header.waitUntilLoadingHasFinished();

await verifyModeHasBeenChanged(INDEX_MODE.LOGSDB);
});
Expand All @@ -262,11 +260,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

await changeIndexMode('index_mode_standard');
// Navigate to the last step of the wizard
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-5');
await pageObjects.header.waitUntilLoadingHasFinished();

await verifyModeHasBeenChanged(INDEX_MODE.STANDARD);
});
Expand All @@ -280,16 +275,14 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

await changeIndexMode('index_mode_logsdb');

await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-2');
await pageObjects.header.waitUntilLoadingHasFinished();
// Modify Index settings
await testSubjects.setValue('kibanaCodeEditor', '{}', {
clearWithKeyboard: true,
});
// Navigate to the last step of the wizard
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-5');

await verifyModeHasBeenChanged(INDEX_MODE.LOGSDB);
});
Expand All @@ -302,8 +295,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

await changeIndexMode('index_mode_time_series');

await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-2');
await pageObjects.header.waitUntilLoadingHasFinished();
// Modify Index settings
await testSubjects.setValue(
'kibanaCodeEditor',
Expand All @@ -313,9 +306,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
}
);
// Navigate to the last step of the wizard
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('formWizardStep-5');

await verifyModeHasBeenChanged(INDEX_MODE.TIME_SERIES);
});
Expand Down
2 changes: 2 additions & 0 deletions ...t_serverless/functional/test_suites/common/management/index_management/index_templates.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,12 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

// Click form summary step and then the submit button
await testSubjects.click('formWizardStep-5');
await pageObjects.header.waitUntilLoadingHasFinished();
expect(await testSubjects.getVisibleText('indexModeValue')).to.be('LogsDB');

// Click update template
await pageObjects.indexManagement.clickNextButton();
await pageObjects.header.waitUntilLoadingHasFinished();

// Close detail tab
expect(await testSubjects.getVisibleText('indexModeValue')).to.be('LogsDB');
Expand Down

0 comments on commit e48679a

Please sign in to comment.