Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiResizableContainer] Fix z-index ui bugs #5164

Merged
merged 2 commits into from
Sep 10, 2021
Merged

[EuiResizableContainer] Fix z-index ui bugs #5164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea1c0ee
update z-indexes
babs20 Sep 9, 2021
f8aeccf
update changelog
babs20 Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- Removed Sass variables for `EuiTabs` font size (`$euiTabFontSize, $euiTabFontSizeS, $euiTabFontSizeL`) ([#5135](https://github.com/elastic/eui/pull/5135))
- Extended all `EuiTabProps` for each `EuiTabbedContentTab` ([#5135](https://github.com/elastic/eui/pull/5135))
- Added `useGeneratedHtmlId` utility, which memoizes the randomly generated ID on mount and prevents regenerated IDs on component rerender ([#5133](https://github.com/elastic/eui/pull/5133))
- Fixed `z-index` styles that were causing parts of `EuiResizableContainer` to overlap `EuiHeader` ([#5164](https://github.com/elastic/eui/pull/5164))

**Theme: Amsterdam**

Expand Down
2 changes: 1 addition & 1 deletion src/components/resizable_container/_resizable_button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
.euiResizableButton {
position: relative;
flex-shrink: 0;
z-index: $euiZLevel1;
z-index: 1;

&:before,
&:after {
Expand Down
2 changes: 1 addition & 1 deletion src/components/resizable_container/_resizable_collapse_button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
.euiResizableToggleButton {
@include euiSlightShadow;
position: absolute;
z-index: $euiZLevel1 + 1;
z-index: 2;
// Remove animations from EuiButtonIcon because of the custom transforms
animation: none !important; // sass-lint:disable-line no-important
// Remove transition from EuiButtonIcon because of the custom transforms
Expand Down