Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiResizableContainer] Fix z-index ui bugs #5164

Merged
merged 2 commits into from
Sep 10, 2021

Conversation

babs20
Copy link
Contributor

@babs20 babs20 commented Sep 9, 2021

Summary

Fixes #5003

This PR changes:

  • .euiResizableButton to use z-index: 1 instead of z-index: $euiZLevel1
  • .euiResizableToggleButton to z-index: 2 instead of z-index: $euiZLevel1 + 1

Both of these changes fix the UI bug which caused the button's separating line and the button itself to overlap the header when the page is scrolled.

Here is a before and after:

Before:

Screen Shot 2021-09-09 at 4 17 59 PM

Screen Shot 2021-09-09 at 6 37 08 PM

After:

Screen Shot 2021-09-09 at 4 15 52 PM

Screen Shot 2021-09-09 at 6 36 05 PM

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
    - [ ] Props have proper autodocs and playground toggles
    - [ ] Added documentation
  • Checked Code Sandbox works for any docs examples
    - [ ] Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@babs20 babs20 marked this pull request as ready for review September 9, 2021 23:02
@babs20 babs20 changed the title [EuiResizableContainer] Fix z-index ui bugs with EuiHeader [EuiResizableContainer] Fix z-index ui bugs Sep 9, 2021
@elizabetdev
Copy link
Contributor

Thanks @babs20 for opening this PR! 🎉 

Let me get our CI running our tests, build a preview, and then I can start a review: jenkins test this.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5164/

Copy link
Contributor

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @babs20! LGTM! 🎉

Tested in Chrome, Safari, Edge, and Firefox.

@elizabetdev elizabetdev merged commit fddd21d into elastic:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiResizableContainer] EuiResizableButton high z-index
4 participants