Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add description for missing fields in Reindex/Update/Delete By Query #26618

Merged
merged 2 commits into from
Sep 15, 2017

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Sep 13, 2017

Some fields lack of a description, I don't think it is intentional.

… Query

Some fields lack of a description, I don't think it is intentional.

`throttled_until_millis`::

Ask Nik. He knows, as always.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! It is "when will this request wake up?" So when you set requests_per_second it will still process a whole batch of results all at once and then it'll sleep for a while to make the indexing rate line up with what you asked for. So this is the the time, in millis since epoch, when the request will wake up and run again. Or it is 0 if we aren't throttled right now.

Honestly it isn't useful in the response because it should always be 0, it is only useful in the task output but the response and the task output are the same because that keeps my life easier.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a short description for this field, pointing to the Task API. Since the field appear in the response I think we should document it.


`version_conflicts`::

The number of version conflicts that the delete by query hit.

`noops`::

The number of documents that were ignored because the script used for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe delete by query supports scripts actually. This is probably just always going to be 0.

This is there because delete-by-query, reindex, and update-by-query always return the same results to keep me sane.

We can probably fix this, but I don't know that it is worth it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks

@tlrx tlrx merged commit 7f74a62 into elastic:master Sep 15, 2017
@tlrx tlrx deleted the add-missing-fields-in-reindex branch September 15, 2017 09:24
tlrx added a commit that referenced this pull request Sep 15, 2017
… Query (#26618)

This commit adds some missing description for some fields
in the Reindex/UBQ/DBQ responses.
tlrx added a commit that referenced this pull request Sep 15, 2017
… Query (#26618)

This commit adds some missing description for some fields
in the Reindex/UBQ/DBQ responses.
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Sep 16, 2017
* master:
  fix testSniffNodes to use the new error message
  Add check for invalid index in WildcardExpressionResolver (elastic#26409)
  Docs: Use single-node discovery.type for dev example
  Filter unsupported relation for range query builder (elastic#26620)
  Fix kuromoji default stoptags (elastic#26600)
  [Docs] Add description for missing fields in Reindex/Update/Delete By Query (elastic#26618)
  [Docs] Update ingest.asciidoc (elastic#26599)
  Better message text for ResponseException
  [DOCS] Remove edit link from ML node
  enable bwc testing
  fix StartRecoveryRequestTests.testSerialization
  Add bad_request to the rest-api-spec catch params (elastic#26539)
  Introduce a History UUID as a requirement for ops based recovery  (elastic#26577)
  Add missing catch arguments to the rest api spec (elastic#26536)
@lcawl lcawl removed the v6.1.0 label Dec 12, 2017
@lcawl lcawl added :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. and removed :Reindex API labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >docs General docs changes v6.0.0-rc1 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants