-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Add description for missing fields in Reindex/Update/Delete By Query #26618
Conversation
… Query Some fields lack of a description, I don't think it is intentional.
|
||
`throttled_until_millis`:: | ||
|
||
Ask Nik. He knows, as always. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha! It is "when will this request wake up?" So when you set requests_per_second
it will still process a whole batch of results all at once and then it'll sleep for a while to make the indexing rate line up with what you asked for. So this is the the time, in millis since epoch, when the request will wake up and run again. Or it is 0 if we aren't throttled right now.
Honestly it isn't useful in the response because it should always be 0, it is only useful in the task output but the response and the task output are the same because that keeps my life easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a short description for this field, pointing to the Task API. Since the field appear in the response I think we should document it.
|
||
`version_conflicts`:: | ||
|
||
The number of version conflicts that the delete by query hit. | ||
|
||
`noops`:: | ||
|
||
The number of documents that were ignored because the script used for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe delete by query supports scripts actually. This is probably just always going to be 0.
This is there because delete-by-query, reindex, and update-by-query always return the same results to keep me sane.
We can probably fix this, but I don't know that it is worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, thanks
… Query (#26618) This commit adds some missing description for some fields in the Reindex/UBQ/DBQ responses.
… Query (#26618) This commit adds some missing description for some fields in the Reindex/UBQ/DBQ responses.
* master: fix testSniffNodes to use the new error message Add check for invalid index in WildcardExpressionResolver (elastic#26409) Docs: Use single-node discovery.type for dev example Filter unsupported relation for range query builder (elastic#26620) Fix kuromoji default stoptags (elastic#26600) [Docs] Add description for missing fields in Reindex/Update/Delete By Query (elastic#26618) [Docs] Update ingest.asciidoc (elastic#26599) Better message text for ResponseException [DOCS] Remove edit link from ML node enable bwc testing fix StartRecoveryRequestTests.testSerialization Add bad_request to the rest-api-spec catch params (elastic#26539) Introduce a History UUID as a requirement for ops based recovery (elastic#26577) Add missing catch arguments to the rest api spec (elastic#26536)
Some fields lack of a description, I don't think it is intentional.