Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing catch arguments to the rest api spec #26536

Merged
merged 2 commits into from
Sep 14, 2017
Merged

Add missing catch arguments to the rest api spec #26536

merged 2 commits into from
Sep 14, 2017

Conversation

hub-cap
Copy link
Contributor

@hub-cap hub-cap commented Sep 7, 2017 •
edited
Loading

image

@hub-cap hub-cap added the :Core/Infra/REST API REST infrastructure and utilities label Sep 7, 2017
@hub-cap hub-cap requested a review from jasontedor September 7, 2017 15:38
jasontedor
jasontedor approved these changes Sep 7, 2017
View reviewed changes
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one comment. It otherwise looks great. Address how you see fit and you can merge without another review from me.

rest-api-spec/src/main/resources/rest-api-spec/test/README.asciidoc Outdated
`request_timeout`:: a 408 response from ES
`conflict`:: a 409 response from ES
`unavailable`:: a 503 response from ES
`request`:: a generic error response from ES
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should be clarified to say that it does not include 401, 403, 404, 408, and 409 and is otherwise any 400 or 500?

@hub-cap
Copy link
Contributor Author

hub-cap commented Sep 7, 2017

image

@hub-cap hub-cap merged commit e69c39a into elastic:master Sep 14, 2017
@hub-cap hub-cap deleted the issues/fix_docs_for_catch branch September 14, 2017 16:05
hub-cap added a commit that referenced this pull request Sep 14, 2017
@hub-cap
Add missing catch arguments to the rest api spec (#26536)
d3afae6
hub-cap added a commit that referenced this pull request Sep 14, 2017
@hub-cap
Add missing catch arguments to the rest api spec (#26536)
667b497
hub-cap added a commit that referenced this pull request Sep 14, 2017
@hub-cap
Add missing catch arguments to the rest api spec (#26536)
be87365
hub-cap added a commit that referenced this pull request Sep 14, 2017
@hub-cap
Add missing catch arguments to the rest api spec (#26536)
ad17546
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Sep 16, 2017
@jasontedor
Merge branch 'master' into track-global-checkpoints
39fcecc 
* master:
  fix testSniffNodes to use the new error message
  Add check for invalid index in WildcardExpressionResolver (elastic#26409)
  Docs: Use single-node discovery.type for dev example
  Filter unsupported relation for range query builder (elastic#26620)
  Fix kuromoji default stoptags (elastic#26600)
  [Docs] Add description for missing fields in Reindex/Update/Delete By Query (elastic#26618)
  [Docs] Update ingest.asciidoc (elastic#26599)
  Better message text for ResponseException
  [DOCS] Remove edit link from ML node
  enable bwc testing
  fix StartRecoveryRequestTests.testSerialization
  Add bad_request to the rest-api-spec catch params (elastic#26539)
  Introduce a History UUID as a requirement for ops based recovery  (elastic#26577)
  Add missing catch arguments to the rest api spec (elastic#26536)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasontedor jasontedor jasontedor approved these changes

Assignees
No one assigned
Labels
:Core/Infra/REST API REST infrastructure and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hub-cap @jasontedor