Adding TransportSimulateShardBulkAction #108795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
added
:Data Management/Ingest Node
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Closing in favor of #109889, which avoids simulate using a ShardBulkAction (and still allows for the possibility of mapping validation in the future). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a TransportSimulateShardBulkAction, meant to be used in simulate ingest in place of TransportShardBulkAction. This delegates virtually all of its logic to TransportShardBulkAction. However, TransportShardBulkAction is a WriteAction and TransportSimulateShardBulkAction is not -- TransportSimulateShardBulkAction does not change state in any way (cluster state, shards, or translog). Since it does not write to shards, it does not need to perform a refresh.
This PR does not actually wire TransportSimulateShardBulkAction up for use by the simulate ingest API (or anything else). See #106440 for the full draft where it is called by BulkOperation (which is called due to the changes in TransportSimulateBulkAction in that PR).
Relates to #108791