Adding isSimulated methods to be used in simulate mapping validation work #108791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
added
>non-issue
:Data Management/Ingest Node
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
This builds on the simulate ingest work from #101409. |
dakrone
approved these changes
May 20, 2024
| @@ -45,13 +53,15 @@ public SimulateIndexResponse( | |||
| long version, | |||
| BytesReference source, | |||
| XContentType sourceXContentType, | |||
| List<String> pipelines | |||
| List<String> pipelines, | |||
| Exception exception | |||
There was a problem hiding this comment.
Perhaps annotate this with @Nullable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lays the groundwork for being able to validate mappings in the simulate ingest API (see #106440 for the full draft). It adds
isSimulatedmethods to BulkRequest, SimulateBulkRequest, and BulkShardRequest. It also adds anexceptionfield to SimulateIndexResponse that will be used to hold any mapping validation exceptions (in a future PR).