Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused scripts for linting and update docs #1663

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

v1v
Copy link
Member

@v1v v1v commented Oct 11, 2022

What does this pull request do?

Remove scripts that are not relevant and update the docs. pre-commit and GitHub actions are now the way.

Related issues

See https://github.com/elastic/apm-agent-python/pull/1661/files#r991956694

@v1v v1v added automation Team:Automation Label for the Observability productivity team labels Oct 11, 2022
@v1v v1v requested review from a team October 11, 2022 08:45
@v1v v1v self-assigned this Oct 11, 2022
@@ -72,5 +72,7 @@ checkout, you might do something like this:

[source,bash]
----
$ ./scripts/compose.py start 7.3 --with-agent-python-django --with-opbeans-python --opbeans-python-agent-local-repo=~/elastic/apm-agent-python
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@beniwohli beniwohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-11T08:45:43.083+0000

  • Duration: 32 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 5029
Skipped 3378
Total 8407

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (67/67) 💚
Files 100.0% (227/227) 💚
Classes 100.0% (227/227) 💚
Lines 91.3% (18070/19792) 👍
Conditionals 74.607% (2800/3753) 👍

@v1v v1v merged commit b5e44db into elastic:main Oct 11, 2022
v1v added a commit to v1v/apm-agent-python that referenced this pull request Oct 12, 2022
…ith-k8s-skaffold

* upstream/main:
  Asgi middleware (elastic#1528)
  chore: remove unused scripts for linting and update docs (elastic#1663)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-python automation Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants