Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asgi middleware #1528

Merged
merged 6 commits into from
Oct 11, 2022
Merged

Asgi middleware #1528

merged 6 commits into from
Oct 11, 2022

Conversation

beniwohli
Copy link
Contributor

exception tracking is still missing, as I haven't figured out
yet why the exception doesn't bubble up to our middleware

What does this pull request do?

Related issues

closes #1341

exception tracking is still missing, as I haven't figured out
yet why the exception doesn't bubble up to our middleware
@apmmachine
Copy link
Contributor

apmmachine commented Apr 13, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-11T12:14:31.101+0000

  • Duration: 30 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 5029
Skipped 3461
Total 8490

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v
Copy link
Member

v1v commented Apr 26, 2022

/test

@apmmachine
Copy link
Contributor

apmmachine commented Apr 26, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (68/68) 💚
Files 100.0% (228/228) 💚
Classes 100.0% (228/228) 💚
Lines 91.011% (18073/19858) 👎 -0.288
Conditionals 74.554% (2801/3757) 👎 -0.053

Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@basepi
Copy link
Contributor

basepi commented May 11, 2022

@beniwohli This just needs a CHANGELOG and it's ready to merge. I also opened #1548 to track the exception handling issue.

@basepi
Copy link
Contributor

basepi commented May 16, 2022

@beniwohli We should probably write some docs on this and mark it as beta since it has the exception-handling issue. Also prominently point out that known issue and link to the open issue.

@estolfo estolfo added this to the 8.6 milestone Sep 28, 2022
@beniwohli beniwohli merged commit 515df75 into elastic:main Oct 11, 2022
@beniwohli beniwohli deleted the asgi-middleware branch October 11, 2022 12:46
v1v added a commit to v1v/apm-agent-python that referenced this pull request Oct 12, 2022
…ith-k8s-skaffold

* upstream/main:
  Asgi middleware (elastic#1528)
  chore: remove unused scripts for linting and update docs (elastic#1663)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Django ASGI support
5 participants