-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asgi middleware #1528
Asgi middleware #1528
Conversation
exception tracking is still missing, as I haven't figured out yet why the exception doesn't bubble up to our middleware
/test |
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@beniwohli This just needs a CHANGELOG and it's ready to merge. I also opened #1548 to track the exception handling issue. |
@beniwohli We should probably write some docs on this and mark it as beta since it has the exception-handling issue. Also prominently point out that known issue and link to the open issue. |
…ith-k8s-skaffold * upstream/main: Asgi middleware (elastic#1528) chore: remove unused scripts for linting and update docs (elastic#1663)
exception tracking is still missing, as I haven't figured out
yet why the exception doesn't bubble up to our middleware
What does this pull request do?
Related issues
closes #1341