Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict length of exception messages #1619

Merged
merged 3 commits into from
Aug 22, 2022

Conversation

basepi
Copy link
Contributor

@basepi basepi commented Aug 18, 2022

What does this pull request do?

Restricts the length of the message field for exceptions captured by the agent. Continuation of the theme in #305.

Related issues

Closes #1614

@apmmachine
Copy link
Contributor

apmmachine commented Aug 18, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-18T22:42:32.026+0000

  • Duration: 30 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 4974
Skipped 3420
Total 8394

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (68/68) 💚
Files 100.0% (227/227) 💚
Classes 100.0% (227/227) 💚
Lines 89.755% (17452/19444) 👍 0.004
Conditionals 77.18% (3186/4128) 👍

Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@basepi basepi merged commit a53260b into elastic:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants