Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the length for all fields #305

Open
alvarolobato opened this issue Oct 23, 2018 · 6 comments
Open

Limit the length for all fields #305

alvarolobato opened this issue Oct 23, 2018 · 6 comments

Comments

@alvarolobato
Copy link

alvarolobato commented Oct 23, 2018

All fields should be limited to KEYWORD_MAX_LENGTH, with the exception of the fields noted in the long fields spec, which should be limited to a length of 10000. Optionally, we can make the latter limit configurable, as stated in the spec.

@alvarolobato alvarolobato added this to the next milestone Nov 21, 2018
@lreuven lreuven removed this from the next milestone Nov 17, 2019
@basepi
Copy link
Contributor

basepi commented Oct 7, 2020

I think this is enforced for most things at this point.

Obviously any keyword fields are already shortened.

@beniwohli I think with the age of this issue I'm going to close it as resolved. If we do run into any more issues I suppose we could write a processor that would shorten everything -- but that's probably not a precise-enough instrument, since different things need to be shortened differently. Keep me posted if you think there's still work to do here.

@basepi basepi closed this as completed Oct 7, 2020
@zube zube bot added [zube]: Done and removed [zube]: Ready labels Oct 7, 2020
@basepi
Copy link
Contributor

basepi commented Oct 7, 2020

Just kidding. Found some more conversation in the cross-agent meta issue, I guess this is still in flux despite the issue-open date. Pardon my noise.

@basepi basepi reopened this Oct 7, 2020
@zube zube bot added [zube]: Inbox and removed [zube]: Done labels Oct 7, 2020
@zube zube bot closed this as completed Oct 7, 2020
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Oct 7, 2020
@zube zube bot reopened this Oct 7, 2020
@zube zube bot added [zube]: Inbox and removed [zube]: Done labels Oct 7, 2020
@zube zube bot closed this as completed Oct 7, 2020
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Oct 7, 2020
@zube zube bot reopened this Oct 7, 2020
@zube zube bot added [zube]: Inbox and removed [zube]: Done labels Oct 7, 2020
@zube zube bot closed this as completed Oct 7, 2020
@zube zube bot removed the [zube]: Inbox label Oct 7, 2020
@zube zube bot added the [zube]: Done label Oct 7, 2020
@zube zube bot reopened this Oct 7, 2020
@zube zube bot added [zube]: Inbox and removed [zube]: Done labels Oct 7, 2020
@zube zube bot closed this as completed Oct 7, 2020
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Oct 7, 2020
@zube zube bot reopened this Oct 7, 2020
@zube zube bot added [zube]: Inbox and removed [zube]: Done labels Oct 7, 2020
@zube zube bot closed this as completed Oct 7, 2020
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Oct 7, 2020
@zube zube bot reopened this Oct 7, 2020
@zube zube bot added [zube]: Inbox and removed [zube]: Done labels Oct 7, 2020
@trentm
Copy link
Member

trentm commented Aug 11, 2022

https://github.com/elastic/apm/blob/main/specs/agents/field-limits.md#long_field_max_length-configuration was spec'd a while ago. That covers a specific set of fields. (The Node.js APM agent truncates other fields at 1024.)

@basepi basepi changed the title Limit the length for non-keyword fields Limit the length for all fields Aug 12, 2022
@basepi
Copy link
Contributor

basepi commented Aug 12, 2022

LONG_FIELD_MAX_LENGTH introduced in #1610 and added to Django's capture_body. First of many places.

@basepi
Copy link
Contributor

basepi commented Aug 18, 2022

Length of exception message field limited in #1619

@basepi
Copy link
Contributor

basepi commented Aug 29, 2022

Length of Starlette bodies limited in #1549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants