Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collider optimization #978

Merged
merged 13 commits into from
Oct 9, 2024

try to fix black CI

7ccf97f
Select commit
Loading
Failed to load commit list.
Merged

Collider optimization #978

try to fix black CI
7ccf97f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 9, 2024 in 0s

88.12% (-3.72%) compared to d437097

View this Pull Request on Codecov

88.12% (-3.72%) compared to d437097

Details

Codecov Report

Attention: Patch coverage is 81.08108% with 14 lines in your changes missing coverage. Please review.

Project coverage is 88.12%. Comparing base (d437097) to head (7ccf97f).
Report is 116 commits behind head on master.

Files with missing lines Patch % Lines
src/sparse.h 15.38% 11 Missing ⚠️
include/manifold/vec_view.h 93.33% 1 Missing ⚠️
src/collider.h 92.30% 1 Missing ⚠️
src/vec.h 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #978      +/-   ##
==========================================
- Coverage   91.84%   88.12%   -3.72%     
==========================================
  Files          37       62      +25     
  Lines        4976     8675    +3699     
  Branches        0     1041    +1041     
==========================================
+ Hits         4570     7645    +3075     
- Misses        406     1030     +624     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.