-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collider optimization #978
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #978 +/- ##
==========================================
- Coverage 91.84% 88.12% -3.72%
==========================================
Files 37 62 +25
Lines 4976 8675 +3699
Branches 0 1041 +1041
==========================================
+ Hits 4570 7645 +3075
- Misses 406 1030 +624 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Any idea what's wrong with the Black formatter?
Hmmm no idea, it seems that everything somehow went wrong. We can try to run the CI again... |
The weird thing is that it starts to fail after the last commit, but the last commit should not affect anything... |
I will investigate this later this week. |
Just got some time, I still don't understand why the previous test failure can happen, but I guess it is caused by the cmake changes in the master branch. The weird thing is that I haven't merged the changes at f632177. Anyway, the tests pass now. For the black formatter error, I think this is caused by the latest version (released a day ago) no longer supports python 3.8, and Ubuntu 20.04 ship with python 3.8 by default. Should be fixed by installing python 3.12. (which I did previously for the cmake formatter because I forgot Ubuntu ships with python preinstalled...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* vec changes * collider optimization * fix tracy * slight optimization for polygon * cleanup * cleanup * CMAKE_CXX_FLAGS should also be a string * slightly optimize polygon * should be lowest instead of min * address comments * update MANIFOLD_PAR guard * try to fix black CI
Unrelated:
Vec
toVecView
.Optimizations:
This results in about 8% time reduction for
perfTest
(2.5s to 2.3s), and 10% time reduction for running triangulation tests (~1900ms to ~1700ms)