Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix explode/0 against Unicode surrogate code points #231

Merged
merged 1 commit into from
Nov 20, 2022
Merged

Fix explode/0 against Unicode surrogate code points #231

merged 1 commit into from
Nov 20, 2022

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Nov 20, 2022

This PR fixes the explode/0 filter on Unicode surrogate code points to be compatible against jq.

 $ jq explode <<< '"\ud83d\ude04"'
[
  128516
]

 $ jackson-jq explode <<< '"\ud83d\ude04"'
[ 55357, 56836 ]

@eiiches
Copy link
Owner

eiiches commented Nov 20, 2022

Good catch! Thank you for the PR!

@eiiches eiiches merged commit 55f57df into eiiches:develop/1.x Nov 20, 2022
itchyny added a commit to itchyny/jackson-jq that referenced this pull request Nov 21, 2022
@itchyny
Fix the explode test case added in eiiches#231
1960816
eiiches added a commit that referenced this pull request Nov 22, 2022
@eiiches
Merge pull request #232 from itchyny/fix-explode-test
fcbe2bb 
Fix the explode test case added in #231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itchyny @eiiches