Merge pull request #231 from itchyny/fix-explode-utf8-codepoint

Fix explode/0 against Unicode surrogate code points
eiiches · Nov 20, 2022 · 55f57df · 55f57df
2 parents f9ca0e5 + f7b0b0b
commit 55f57df
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/jackson-jq/src/main/java/net/thisptr/jackson/jq/internal/functions/ExplodeFunction.java b/jackson-jq/src/main/java/net/thisptr/jackson/jq/internal/functions/ExplodeFunction.java
@@ -25,8 +25,8 @@ public void apply(final Scope scope, final List<Expression> args, final JsonNode
 		Preconditions.checkInputType("explode", in, JsonNodeType.STRING);
 
 		final ArrayNode result = scope.getObjectMapper().createArrayNode();
-		for (final char ch : in.asText().toCharArray())
-			result.add((int) ch);
+		for (final int ch : in.asText().codePoints().toArray())
+			result.add(ch);
 		output.emit(result, null);
 	}
 }
diff --git a/jackson-jq/src/test/resources/tests/functions/explode.yaml b/jackson-jq/src/test/resources/tests/functions/explode.yaml
@@ -0,0 +1,4 @@
+- q: 'explode'
+  in: "\\ud83d\\ude04"
+  out:
+  - 128516